Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 1529623002: Update the keyLocation deprecation message for M50 removal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: oops Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 726 matching lines...) Expand 10 before | Expand all | Expand 10 after
737 737
738 String UseCounter::deprecationMessage(Feature feature) 738 String UseCounter::deprecationMessage(Feature feature)
739 { 739 {
740 switch (feature) { 740 switch (feature) {
741 // Quota 741 // Quota
742 case PrefixedStorageInfo: 742 case PrefixedStorageInfo:
743 return "'window.webkitStorageInfo' is deprecated. Please use 'navigator. webkitTemporaryStorage' or 'navigator.webkitPersistentStorage' instead."; 743 return "'window.webkitStorageInfo' is deprecated. Please use 'navigator. webkitTemporaryStorage' or 'navigator.webkitPersistentStorage' instead.";
744 744
745 // Keyboard Event (DOM Level 3) 745 // Keyboard Event (DOM Level 3)
746 case KeyboardEventKeyLocation: 746 case KeyboardEventKeyLocation:
747 return replacedBy("KeyboardEvent.keyLocation", "KeyboardEvent.location") ; 747 return "'KeyboardEvent.keyLocation' is deprecated and will be removed in M50, around April 2016. Please use 'KeyboardEvent.location' instead. See https: //www.chromestatus.com/features/4997403308457984 for more details.";
jochen (gone - plz use gerrit) 2015/12/16 08:55:58 I wonder whether we should have a generator functi
philipj_slow 2015/12/18 10:56:43 Rebased!
748 748
749 case ConsoleMarkTimeline: 749 case ConsoleMarkTimeline:
750 return replacedBy("console.markTimeline", "console.timeStamp"); 750 return replacedBy("console.markTimeline", "console.timeStamp");
751 751
752 case FileError: 752 case FileError:
753 return "FileError is deprecated. Please use the 'name' or 'message' attr ibutes of DOMError rather than 'code'."; 753 return "FileError is deprecated. Please use the 'name' or 'message' attr ibutes of DOMError rather than 'code'.";
754 754
755 case CSSStyleSheetInsertRuleOptionalArg: 755 case CSSStyleSheetInsertRuleOptionalArg:
756 return "Calling CSSStyleSheet.insertRule() with one argument is deprecat ed. Please pass the index argument as well: insertRule(x, 0)."; 756 return "Calling CSSStyleSheet.insertRule() with one argument is deprecat ed. Please pass the index argument as well: insertRule(x, 0).";
757 757
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
976 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 976 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
977 { 977 {
978 // FIXME: We may want to handle stylesheets that have multiple owners 978 // FIXME: We may want to handle stylesheets that have multiple owners
979 // https://crbug.com/242125 979 // https://crbug.com/242125
980 if (sheetContents && sheetContents->hasSingleOwnerNode()) 980 if (sheetContents && sheetContents->hasSingleOwnerNode())
981 return getFrom(sheetContents->singleOwnerDocument()); 981 return getFrom(sheetContents->singleOwnerDocument());
982 return 0; 982 return 0;
983 } 983 }
984 984
985 } // namespace blink 985 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698