Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1529623002:
Update the keyLocation deprecation message for M50 removal (Closed)
|
Created:
5 years ago by philipj_slow Modified:
5 years ago Reviewers:
jochen (gone - plz use gerrit) CC:
blink-reviews, chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate the keyLocation deprecation message for M50 removal
Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/lqknEaUYCJM/UbNahDDMAwAJ
BUG=568261
Committed: https://crrev.com/4533b0910849a8eab2559c02da76990d299638d5
Cr-Commit-Position: refs/heads/master@{#366112}
Patch Set 1 #Patch Set 2 : oops #
Total comments: 2
Patch Set 3 : use replacedWillBeRemoved #
Messages
Total messages: 25 (11 generated)
The CQ bit was checked by philipj@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529623002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by philipj@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529623002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by philipj@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529623002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
philipj@opera.com changed reviewers: + jochen@chromium.org
PTAL and CQ?
Description was changed from ========== Update the keyLocation deprecation message for M50 removal BUG=568261 ========== to ========== Update the keyLocation deprecation message for M50 removal Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/lqknEaUYCJM/UbNahDDM... BUG=568261 ==========
lgtm either way https://codereview.chromium.org/1529623002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/1529623002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/frame/UseCounter.cpp:747: return "'KeyboardEvent.keyLocation' is deprecated and will be removed in M50, around April 2016. Please use 'KeyboardEvent.location' instead. See https://www.chromestatus.com/features/4997403308457984 for more details."; I wonder whether we should have a generator function for this string as well? something like replacedBy("KeyboardEvent.keyLocation", 50, "4997403308457984")
https://codereview.chromium.org/1529623002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/1529623002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/frame/UseCounter.cpp:747: return "'KeyboardEvent.keyLocation' is deprecated and will be removed in M50, around April 2016. Please use 'KeyboardEvent.location' instead. See https://www.chromestatus.com/features/4997403308457984 for more details."; On 2015/12/16 08:55:58, jochen wrote: > I wonder whether we should have a generator function for this string as well? > something like replacedBy("KeyboardEvent.keyLocation", 50, "4997403308457984") Rebased!
On 2015/12/18 at 10:56:43, philipj wrote: > https://codereview.chromium.org/1529623002/diff/20001/third_party/WebKit/Sour... > File third_party/WebKit/Source/core/frame/UseCounter.cpp (right): > > https://codereview.chromium.org/1529623002/diff/20001/third_party/WebKit/Sour... > third_party/WebKit/Source/core/frame/UseCounter.cpp:747: return "'KeyboardEvent.keyLocation' is deprecated and will be removed in M50, around April 2016. Please use 'KeyboardEvent.location' instead. See https://www.chromestatus.com/features/4997403308457984 for more details."; > On 2015/12/16 08:55:58, jochen wrote: > > I wonder whether we should have a generator function for this string as well? > > something like replacedBy("KeyboardEvent.keyLocation", 50, "4997403308457984") > > Rebased! Still lgtm Feel free to just cq the other two cls after rebasing
On 2015/12/18 11:01:41, jochen wrote: > On 2015/12/18 at 10:56:43, philipj wrote: > > > https://codereview.chromium.org/1529623002/diff/20001/third_party/WebKit/Sour... > > File third_party/WebKit/Source/core/frame/UseCounter.cpp (right): > > > > > https://codereview.chromium.org/1529623002/diff/20001/third_party/WebKit/Sour... > > third_party/WebKit/Source/core/frame/UseCounter.cpp:747: return > "'KeyboardEvent.keyLocation' is deprecated and will be removed in M50, around > April 2016. Please use 'KeyboardEvent.location' instead. See > https://www.chromestatus.com/features/4997403308457984 for more details."; > > On 2015/12/16 08:55:58, jochen wrote: > > > I wonder whether we should have a generator function for this string as > well? > > > something like replacedBy("KeyboardEvent.keyLocation", 50, > "4997403308457984") > > > > Rebased! > > Still lgtm > > Feel free to just cq the other two cls after rebasing Yep, just have to wait for the helper CL to land.
The CQ bit was checked by philipj@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529623002/40001
Message was sent while issue was closed.
Description was changed from ========== Update the keyLocation deprecation message for M50 removal Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/lqknEaUYCJM/UbNahDDM... BUG=568261 ========== to ========== Update the keyLocation deprecation message for M50 removal Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/lqknEaUYCJM/UbNahDDM... BUG=568261 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Update the keyLocation deprecation message for M50 removal Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/lqknEaUYCJM/UbNahDDM... BUG=568261 ========== to ========== Update the keyLocation deprecation message for M50 removal Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/lqknEaUYCJM/UbNahDDM... BUG=568261 Committed: https://crrev.com/4533b0910849a8eab2559c02da76990d299638d5 Cr-Commit-Position: refs/heads/master@{#366112} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4533b0910849a8eab2559c02da76990d299638d5 Cr-Commit-Position: refs/heads/master@{#366112} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
