Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1529473002: [proxies] [tests] Un-skip proxies-with-unscopables, delete proxies-symbols (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] [tests] Un-skip proxies-with-unscopables, delete proxies-symbols - proxies-with-unscopables needed updating of trap names - proxies-symbols doesn't make sense any more: it tested symbol fitering/ blacklisting, but Proxies interact with Symbols just fine according to the current spec. BUG=v8:1543 LOG=n Committed: https://crrev.com/0e2ea6a508b18a807a4192e6f578051a773aac87 Cr-Commit-Position: refs/heads/master@{#32844}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -148 lines) Patch
D test/mjsunit/harmony/proxies-symbols.js View 1 chunk +0 lines, -108 lines 0 comments Download
M test/mjsunit/harmony/proxies-with-unscopables.js View 1 6 chunks +29 lines, -38 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Jakob Kummerow
PTAL.
5 years ago (2015-12-14 15:36:04 UTC) #2
neis
lgtm https://codereview.chromium.org/1529473002/diff/1/test/mjsunit/harmony/proxies-with-unscopables.js File test/mjsunit/harmony/proxies-with-unscopables.js (right): https://codereview.chromium.org/1529473002/diff/1/test/mjsunit/harmony/proxies-with-unscopables.js#newcode12 test/mjsunit/harmony/proxies-with-unscopables.js:12: Why not use String(x)? Then you can test ...
5 years ago (2015-12-14 15:53:55 UTC) #3
Jakob Kummerow
Thanks, I was looking for that trick :-) https://codereview.chromium.org/1529473002/diff/1/test/mjsunit/harmony/proxies-with-unscopables.js File test/mjsunit/harmony/proxies-with-unscopables.js (right): https://codereview.chromium.org/1529473002/diff/1/test/mjsunit/harmony/proxies-with-unscopables.js#newcode12 test/mjsunit/harmony/proxies-with-unscopables.js:12: On ...
5 years ago (2015-12-14 15:59:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529473002/20001
5 years ago (2015-12-14 15:59:18 UTC) #7
commit-bot: I haz the power
Exceeded global retry quota
5 years ago (2015-12-14 15:59:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529473002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529473002/40001
5 years ago (2015-12-14 16:13:54 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-14 16:37:08 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-14 16:38:05 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0e2ea6a508b18a807a4192e6f578051a773aac87
Cr-Commit-Position: refs/heads/master@{#32844}

Powered by Google App Engine
This is Rietveld 408576698