Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: test/mjsunit/harmony/proxies-symbols.js

Issue 1529473002: [proxies] [tests] Un-skip proxies-with-unscopables, delete proxies-symbols (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebased Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/harmony/proxies-with-unscopables.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/harmony/proxies-symbols.js
diff --git a/test/mjsunit/harmony/proxies-symbols.js b/test/mjsunit/harmony/proxies-symbols.js
deleted file mode 100644
index 35e8a8fb5fc76380cd5e0957cc282c8b0a2b828d..0000000000000000000000000000000000000000
--- a/test/mjsunit/harmony/proxies-symbols.js
+++ /dev/null
@@ -1,108 +0,0 @@
-// Copyright 2013 the V8 project authors. All rights reserved.
-// Redistribution and use in source and binary forms, with or without
-// modification, are permitted provided that the following conditions are
-// met:
-//
-// * Redistributions of source code must retain the above copyright
-// notice, this list of conditions and the following disclaimer.
-// * Redistributions in binary form must reproduce the above
-// copyright notice, this list of conditions and the following
-// disclaimer in the documentation and/or other materials provided
-// with the distribution.
-// * Neither the name of Google Inc. nor the names of its
-// contributors may be used to endorse or promote products derived
-// from this software without specific prior written permission.
-//
-// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-// Flags: --harmony-proxies
-
-
-// Helper.
-
-function TestWithProxies(test, x, y, z) {
- test(function(h) { return new Proxy({}, h) }, x, y, z)
- test(function(h) {
- return Proxy.createFunction(h, function() {})
- }, x, y, z)
-}
-
-
-// No symbols should leak to proxy traps.
-
-function TestNoSymbolsToTrap(handler) {
- TestWithProxies(TestNoSymbolsToTrap2, handler)
-}
-
-function TestNoSymbolsToTrap2(create, handler) {
- var p = create(handler)
- var o = Object.create(p)
- var symbol = Symbol("secret")
-
- assertFalse(symbol in p)
- assertFalse(symbol in o)
- assertEquals(undefined, p[symbol])
- assertEquals(undefined, o[symbol])
- assertEquals(47, p[symbol] = 47)
- assertEquals(47, o[symbol] = 47)
- assertFalse(delete p[symbol])
- assertTrue(delete o[symbol])
- assertTrue(delete o[symbol])
- assertFalse({}.hasOwnProperty.call(p, symbol))
- assertFalse({}.hasOwnProperty.call(o, symbol))
- assertEquals(undefined, Object.getOwnPropertyDescriptor(p, symbol))
- assertEquals(undefined, Object.getOwnPropertyDescriptor(o, symbol))
-}
-
-
-TestNoSymbolsToTrap({
- has: assertUnreachable,
- hasOwn: assertUnreachable,
- get: assertUnreachable,
- set: assertUnreachable,
- delete: assertUnreachable,
- getPropertyDescriptor: assertUnreachable,
- getOwnPropertyDescriptor: assertUnreachable,
- defineProperty: assertUnreachable
-})
-
-
-// All symbols returned from proxy traps should be filtered.
-
-function TestNoSymbolsFromTrap(handler) {
- TestWithProxies(TestNoSymbolsFromTrap2, handler)
-}
-
-function TestNoSymbolsFromTrap2(create, handler) {
- var p = create(handler)
- var o = Object.create(p)
-
- assertEquals(0, Object.keys(p).length)
- assertEquals(0, Object.keys(o).length)
- assertEquals(0, Object.getOwnPropertyNames(p).length)
- assertEquals(0, Object.getOwnPropertyNames(o).length)
- for (var n in p) assertUnreachable()
- for (var n in o) assertUnreachable()
-}
-
-
-function MakeSymbolArray() {
- return [Symbol(), Symbol("a")]
-}
-
-TestNoSymbolsFromTrap({
- enumerate: MakeSymbolArray,
- keys: MakeSymbolArray,
- getPropertyNames: MakeSymbolArray,
- getOwnPropertyNames: MakeSymbolArray
-})
« no previous file with comments | « no previous file | test/mjsunit/harmony/proxies-with-unscopables.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698