Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1694)

Unified Diff: chrome/browser/ui/webui/chromeos/login/network_state_informer.cc

Issue 15294010: Remove NetworkStateInformer's dependency on ProxyConfigServiceImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed IsProxyConfigured. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/network_state_informer.h ('k') | chromeos/network/managed_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/login/network_state_informer.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/network_state_informer.cc b/chrome/browser/ui/webui/chromeos/login/network_state_informer.cc
index a87c290c073babe7bd4fb9e0b04fd570a8a6e523..28832bc4dfb91f47e5e66cd3c18d4151addb4d4d 100644
--- a/chrome/browser/ui/webui/chromeos/login/network_state_informer.cc
+++ b/chrome/browser/ui/webui/chromeos/login/network_state_informer.cc
@@ -7,7 +7,8 @@
#include "base/bind.h"
#include "base/logging.h"
#include "base/message_loop.h"
-#include "chrome/browser/chromeos/proxy_config_service_impl.h"
+#include "chrome/browser/prefs/proxy_config_dictionary.h"
+#include "chrome/browser/prefs/proxy_prefs.h"
#include "chrome/common/chrome_notification_types.h"
#include "chromeos/network/network_state.h"
#include "chromeos/network/network_state_handler.h"
@@ -24,7 +25,8 @@ const int kNetworkStateCheckDelaySec = 3;
namespace chromeos {
NetworkStateInformer::NetworkStateInformer()
- : state_(OFFLINE) {
+ : state_(OFFLINE),
+ weak_ptr_factory_(this) {
}
NetworkStateInformer::~NetworkStateInformer() {
@@ -89,7 +91,7 @@ void NetworkStateInformer::NetworkManagerChanged() {
check_state_.Cancel();
check_state_.Reset(
base::Bind(&NetworkStateInformer::UpdateStateAndNotify,
- base::Unretained(this)));
+ weak_ptr_factory_.GetWeakPtr()));
base::MessageLoop::current()->PostDelayedTask(
FROM_HERE,
check_state_.callback(),
@@ -211,19 +213,9 @@ NetworkStateInformer::State NetworkStateInformer::GetNetworkState(
bool NetworkStateInformer::IsProxyConfigured(const NetworkState* network) {
DCHECK(network);
- ProxyStateMap::iterator it = proxy_state_map_.find(network->guid());
- if (it != proxy_state_map_.end() &&
- it->second.proxy_config == network->proxy_config()) {
- return it->second.configured;
- }
- net::ProxyConfig proxy_config;
- if (!ProxyConfigServiceImpl::ParseProxyConfig(network->proxy_config(),
- &proxy_config))
- return false;
- bool configured = !proxy_config.proxy_rules().empty();
- proxy_state_map_[network->guid()] =
- ProxyState(network->proxy_config(), configured);
- return configured;
+ ProxyConfigDictionary proxy_dict(&network->proxy_config());
+ ProxyPrefs::ProxyMode mode;
+ return proxy_dict.GetMode(&mode) && mode == ProxyPrefs::MODE_FIXED_SERVERS;
}
} // namespace chromeos
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/network_state_informer.h ('k') | chromeos/network/managed_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698