Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: chromeos/network/managed_state.h

Issue 15294010: Remove NetworkStateInformer's dependency on ProxyConfigServiceImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed IsProxyConfigured. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/network_state_informer.cc ('k') | chromeos/network/network_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/managed_state.h
diff --git a/chromeos/network/managed_state.h b/chromeos/network/managed_state.h
index 8fc198d61ab068764cab39fb9b0a0b708f702b67..f128edcc26494294015abdc822ea986adb8d8367 100644
--- a/chromeos/network/managed_state.h
+++ b/chromeos/network/managed_state.h
@@ -40,9 +40,14 @@ class ManagedState {
NetworkState* AsNetworkState();
DeviceState* AsDeviceState();
- // Called by NetworkStateHandler when a property changes. Returns false if
- // the property was not recognized, was not parsed successfully, or is
- // unchanged (complex properties may be assumed to have changed).
+ // Called by NetworkStateHandler when a property was received. The return
+ // value indicates if the state changed and is used to reduce the number of
+ // notifications. The only guarantee however is: If the return value is false
+ // then the state wasn't modified. This might happen because of
+ // * |key| was not recognized.
+ // * |value| was not parsed successfully.
+ // * |value| is equal to the cached property value.
+ // If the return value is true, the state might or might not be modified.
virtual bool PropertyChanged(const std::string& key,
const base::Value& value) = 0;
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/network_state_informer.cc ('k') | chromeos/network/network_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698