third_party/WebKit/Source/core/html/HTMLInputElement.cpp - Issue 1529373002: Fix a crash by search event handler for <input type=search incremental>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 1529373002: Fix a crash by search event handler for <input type=search incremental>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/search/search-change-type-onsearch.html ('k') | third_party/WebKit/Source/core/html/forms/SearchInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

index 78231dff72825e02578b6097ec4dd55a79cd8355..e816a553b7e3dd837359aa60e1f02e99a8104d7a 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

@@ -37,6 +37,7 @@

#include "core/InputTypeNames.h"

#include "core/dom/AXObjectCache.h"

#include "core/dom/Document.h"

+#include "core/dom/ExecutionContextTask.h"

#include "core/dom/IdTargetObserver.h"

#include "core/dom/shadow/InsertionPoint.h"

#include "core/dom/shadow/ShadowRoot.h"

@@ -1235,7 +1236,7 @@ void HTMLInputElement::defaultEventHandler(Event* evt)

if (m_inputTypeView->shouldSubmitImplicitly(evt)) {

// FIXME: Remove type check.

if (type() == InputTypeNames::search)

- onSearch();

+ document().postTask(BLINK_FROM_HERE, createSameThreadTask(&HTMLInputElement::onSearch, PassRefPtrWillBeRawPtr<HTMLInputElement>(this)));

// Form submission finishes editing, just as loss of focus does.

// If there was a change, send the event now.

if (wasChangedSinceLastFormControlChangeEvent())