Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1529303004: Convert Pass()→std::move() in mojo/edk/ (Closed)

Created:
5 years ago by dcheng
Modified:
5 years ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //mojo/edk BUG=557422 R=avi@chromium.org TBR=ben@chromium.org Committed: https://crrev.com/2a370ee9320230d59b317e23e1778846c8d8035d Cr-Commit-Position: refs/heads/master@{#366167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -197 lines) Patch
M mojo/edk/embedder/embedder.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M mojo/edk/embedder/embedder_unittest.cc View 3 chunks +10 lines, -6 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair_posix_unittest.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M mojo/edk/embedder/simple_platform_shared_buffer.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/embedder/simple_platform_shared_buffer_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/embedder/simple_platform_shared_buffer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/embedder/simple_platform_support.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/edk/js/tests/js_to_cpp_tests.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M mojo/edk/system/child_broker.cc View 8 chunks +11 lines, -9 lines 0 comments Download
M mojo/edk/system/child_broker_host.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M mojo/edk/system/core.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M mojo/edk/system/message_in_transit.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 10 chunks +17 lines, -17 lines 0 comments Download
M mojo/edk/system/message_pipe_perftest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 15 chunks +28 lines, -27 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.h View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M mojo/edk/system/raw_channel.cc View 7 chunks +8 lines, -9 lines 0 comments Download
M mojo/edk/system/raw_channel_posix.cc View 8 chunks +12 lines, -12 lines 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 11 chunks +17 lines, -16 lines 0 comments Download
M mojo/edk/system/routed_raw_channel.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M mojo/edk/system/transport_data.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M mojo/edk/test/multiprocess_test_helper.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/edk/test/multiprocess_test_helper_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/test/test_utils_posix.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
dcheng
5 years ago (2015-12-18 09:14:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529303004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529303004/1
5 years ago (2015-12-18 09:15:03 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-18 10:18:15 UTC) #7
Avi (use Gerrit)
stampity stamp lgtm
5 years ago (2015-12-18 20:58:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529303004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529303004/1
5 years ago (2015-12-18 20:59:53 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 21:07:26 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-18 21:08:47 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2a370ee9320230d59b317e23e1778846c8d8035d
Cr-Commit-Position: refs/heads/master@{#366167}

Powered by Google App Engine
This is Rietveld 408576698