Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: mojo/edk/js/tests/js_to_cpp_tests.cc

Issue 1529303004: Convert Pass()→std::move() in mojo/edk/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/embedder/simple_platform_support.cc ('k') | mojo/edk/system/child_broker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/js/tests/js_to_cpp_tests.cc
diff --git a/mojo/edk/js/tests/js_to_cpp_tests.cc b/mojo/edk/js/tests/js_to_cpp_tests.cc
index fd0a8465b82cd80fc209f2839cd8cecbae1c891d..1b96610ad5045cefff25fe8e4fd745b9107208b6 100644
--- a/mojo/edk/js/tests/js_to_cpp_tests.cc
+++ b/mojo/edk/js/tests/js_to_cpp_tests.cc
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <utility>
+
#include "base/at_exit.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
@@ -98,8 +100,8 @@ js_to_cpp::EchoArgsPtr BuildSampleEchoArgs() {
string_array[0] = "one";
string_array[1] = "two";
string_array[2] = "three";
- args->string_array = string_array.Pass();
- return args.Pass();
+ args->string_array = std::move(string_array);
+ return args;
}
void CheckSampleEchoArgs(const js_to_cpp::EchoArgs& arg) {
@@ -208,7 +210,7 @@ class CppSideConnection : public js_to_cpp::CppSide {
js_to_cpp::JsSide* js_side() { return js_side_; }
void Bind(InterfaceRequest<js_to_cpp::CppSide> request) {
- binding_.Bind(request.Pass());
+ binding_.Bind(std::move(request));
// Keep the pipe open even after validation errors.
binding_.EnableTestingMode();
}
@@ -378,7 +380,7 @@ class JsToCppTest : public testing::Test {
js_to_cpp::CppSidePtr cpp_side_ptr;
cpp_side->Bind(GetProxy(&cpp_side_ptr));
- js_side->SetCppSide(cpp_side_ptr.Pass());
+ js_side->SetCppSide(std::move(cpp_side_ptr));
gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,
gin::IsolateHolder::kStableV8Extras,
« no previous file with comments | « mojo/edk/embedder/simple_platform_support.cc ('k') | mojo/edk/system/child_broker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698