src/x64/lithium-codegen-x64.cc - Issue 152923006: Fix for a smi stores optimization on x64 with a test case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 152923006: Fix for a smi stores optimization on x64 with a test case. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index ff9caa527c5649ba12481ad1bc132a342467376e..e006ba8492842606ec3901d6e1f8dfa271c4c276 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -3929,6 +3929,10 @@ void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) {

if (representation.IsSmi() &&

hinstr->value()->representation().IsInteger32()) {

ASSERT(hinstr->store_mode() == STORE_TO_INITIALIZED_ENTRY);

+#ifdef DEBUG

+ __ movq(kScratchRegister, FieldOperand(write_register, offset));

+ __ AssertSmi(kScratchRegister);

+#endif

// Store int value directly to upper half of the smi.

STATIC_ASSERT(kSmiTag == 0);

STATIC_ASSERT(kSmiTagSize + kSmiShiftSize == 32);

« no previous file with comments | « src/hydrogen-instructions.h ('k') | test/mjsunit/compiler/smi-stores-opt.js » ('j') | no next file with comments »