Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1529033002: Add two UseCounters for form.imageName and form.elements.imageName. (Closed)

Created:
5 years ago by tkent
Modified:
5 years ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add two UseCounters for form.imageName and form.elements.imageName. https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/DPFNigRT6Dc/5ck9egACBAAJ > A) What the specification defines; form.imageName where |imageName| is a > descendant of |form|. > > B) What the specification lacks, and all browsers agree; form.imageName where > |imageName| is not a descendant of |form| and is associated by HTML parser. > > C) WebKit-only quirk: form.elements.imageName This CL adds UseCounter::FormNameAccessForNonDescendantImageElement for B. UseCounter::FormControlsCollectionNameAccessForImageElement for C. BUG=570151 Committed: https://crrev.com/dc1e9e51df9ef1b02bc0b9045c5fe2a64fc3b79f Cr-Commit-Position: refs/heads/master@{#365468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
tkent
kochi@, would you review this please?
5 years ago (2015-12-16 03:58:00 UTC) #3
kochi
lgtm
5 years ago (2015-12-16 04:17:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529033002/1
5 years ago (2015-12-16 04:39:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 05:36:34 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-16 05:38:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc1e9e51df9ef1b02bc0b9045c5fe2a64fc3b79f
Cr-Commit-Position: refs/heads/master@{#365468}

Powered by Google App Engine
This is Rietveld 408576698