Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1528983005: [turbofan] Print APIs for live ranges. (Closed)

Created:
5 years ago by Mircea Trofin
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Print APIs for live ranges. Decoupled the Print APIs from RegisterAllocationData, and placed them on the various APIs. Way easier to use these at debug time even outside the register allocation pipeline. BUG= Committed: https://crrev.com/fe7001ab4856f65b6d3c6df538a6475c2206075d Cr-Commit-Position: refs/heads/master@{#32930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -75 lines) Patch
M src/compiler/instruction.h View 4 chunks +11 lines, -0 lines 0 comments Download
M src/compiler/instruction.cc View 4 chunks +66 lines, -0 lines 0 comments Download
M src/compiler/register-allocator.h View 4 chunks +5 lines, -7 lines 0 comments Download
M src/compiler/register-allocator.cc View 4 chunks +41 lines, -68 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Mircea Trofin
One more try for the Print APIs for debugging (the register allocation model).
5 years ago (2015-12-17 04:51:05 UTC) #3
Benedikt Meurer
lgtm
5 years ago (2015-12-17 05:06:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528983005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528983005/1
5 years ago (2015-12-17 05:06:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528983005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528983005/1
5 years ago (2015-12-17 08:22:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528983005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528983005/1
5 years ago (2015-12-17 08:31:55 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 08:42:13 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-17 08:42:27 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe7001ab4856f65b6d3c6df538a6475c2206075d
Cr-Commit-Position: refs/heads/master@{#32930}

Powered by Google App Engine
This is Rietveld 408576698