Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1528983004: Add support for the "external" keyword to summaries. (Closed)

Created:
5 years ago by Paul Berry
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -2 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 6 chunks +14 lines, -2 lines 2 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 9 chunks +40 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 9 chunks +86 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
5 years ago (2015-12-16 21:21:53 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1528983004/diff/1/pkg/analyzer/lib/src/summary/format.dart File pkg/analyzer/lib/src/summary/format.dart (right): https://codereview.chromium.org/1528983004/diff/1/pkg/analyzer/lib/src/summary/format.dart#newcode575 pkg/analyzer/lib/src/summary/format.dart:575: _isExternal = json["isExternal"]; Perhaps use constants rather than ...
5 years ago (2015-12-16 21:26:02 UTC) #3
Paul Berry
https://codereview.chromium.org/1528983004/diff/1/pkg/analyzer/lib/src/summary/format.dart File pkg/analyzer/lib/src/summary/format.dart (right): https://codereview.chromium.org/1528983004/diff/1/pkg/analyzer/lib/src/summary/format.dart#newcode575 pkg/analyzer/lib/src/summary/format.dart:575: _isExternal = json["isExternal"]; On 2015/12/16 21:26:02, Brian Wilkerson wrote: ...
5 years ago (2015-12-16 21:27:44 UTC) #4
Paul Berry
5 years ago (2015-12-16 21:32:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ac170168dd988e17727c666f69b05db2cd4ac377 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698