Add support for the "external" keyword to summaries.

pkg/analyzer/lib/src/summary/format.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // This file has been automatically generated.  Please do not edit it manually.
 // To regenerate the file, use the script "pkg/analyzer/tool/generate_files".
 
 library analyzer.src.summary.format;
 
 import 'dart:convert';
@@ skipping 541 matching lines @@
   String _name;
   List<UnlinkedTypeParam> _typeParameters;
   UnlinkedTypeRef _returnType;
   List<UnlinkedParam> _parameters;
   UnlinkedExecutableKind _kind;
   bool _isAbstract;
   bool _isStatic;
   bool _isConst;
   bool _isFactory;
   bool _hasImplicitReturnType;
+  bool _isExternal;
 
   UnlinkedExecutable.fromJson(Map json)
     : _name = json["name"],
       _typeParameters = json["typeParameters"]?.map((x) => new UnlinkedTypeParam.fromJson(x))?.toList(),
       _returnType = json["returnType"] == null ? null : new UnlinkedTypeRef.fromJson(json["returnType"]),
       _parameters = json["parameters"]?.map((x) => new UnlinkedParam.fromJson(x))?.toList(),
       _kind = json["kind"] == null ? null : UnlinkedExecutableKind.values[json["kind"]],
       _isAbstract = json["isAbstract"],
       _isStatic = json["isStatic"],
       _isConst = json["isConst"],
       _isFactory = json["isFactory"],
-      _hasImplicitReturnType = json["hasImplicitReturnType"];
+      _hasImplicitReturnType = json["hasImplicitReturnType"],
+      _isExternal = json["isExternal"];

[Brian Wilkerson, 2015/12/16 21:26:02]

Perhaps use constants rather than literal strings to ensure consistency?

[Paul Berry, 2015/12/16 21:27:44]

This is generated code so I'm not too worried about consistency.  Besides, in
the long term, I expect to replace the JSON format with a more compact (and
faster) binary format.

 
   String get name => _name ?? '';
   List<UnlinkedTypeParam> get typeParameters => _typeParameters ?? const <UnlinkedTypeParam>[];
   UnlinkedTypeRef get returnType => _returnType;
   List<UnlinkedParam> get parameters => _parameters ?? const <UnlinkedParam>[];
   UnlinkedExecutableKind get kind => _kind ?? UnlinkedExecutableKind.functionOrMethod;
   bool get isAbstract => _isAbstract ?? false;
   bool get isStatic => _isStatic ?? false;
   bool get isConst => _isConst ?? false;
   bool get isFactory => _isFactory ?? false;
   bool get hasImplicitReturnType => _hasImplicitReturnType ?? false;
+  bool get isExternal => _isExternal ?? false;
 }
 
 class UnlinkedExecutableBuilder {
   final Map _json = {};
 
   bool _finished = false;
 
   UnlinkedExecutableBuilder(builder.BuilderContext context);
 
   void set name(String _value) {
@@ skipping 69 matching lines @@
   }
 
   void set hasImplicitReturnType(bool _value) {
     assert(!_finished);
     assert(!_json.containsKey("hasImplicitReturnType"));
     if (_value != null) {
       _json["hasImplicitReturnType"] = _value;
     }
   }
 
+  void set isExternal(bool _value) {
+    assert(!_finished);
+    assert(!_json.containsKey("isExternal"));
+    if (_value != null) {
+      _json["isExternal"] = _value;
+    }
+  }
+
   Map finish() {
     assert(!_finished);
     _finished = true;
     return _json;
   }
 }
 
-UnlinkedExecutableBuilder encodeUnlinkedExecutable(builder.BuilderContext builderContext, {String name, List<UnlinkedTypeParamBuilder> typeParameters, UnlinkedTypeRefBuilder returnType, List<UnlinkedParamBuilder> parameters, UnlinkedExecutableKind kind, bool isAbstract, bool isStatic, bool isConst, bool isFactory, bool hasImplicitReturnType}) {
+UnlinkedExecutableBuilder encodeUnlinkedExecutable(builder.BuilderContext builderContext, {String name, List<UnlinkedTypeParamBuilder> typeParameters, UnlinkedTypeRefBuilder returnType, List<UnlinkedParamBuilder> parameters, UnlinkedExecutableKind kind, bool isAbstract, bool isStatic, bool isConst, bool isFactory, bool hasImplicitReturnType, bool isExternal}) {
   UnlinkedExecutableBuilder builder = new UnlinkedExecutableBuilder(builderContext);
   builder.name = name;
   builder.typeParameters = typeParameters;
   builder.returnType = returnType;
   builder.parameters = parameters;
   builder.kind = kind;
   builder.isAbstract = isAbstract;
   builder.isStatic = isStatic;
   builder.isConst = isConst;
   builder.isFactory = isFactory;
   builder.hasImplicitReturnType = hasImplicitReturnType;
+  builder.isExternal = isExternal;
   return builder;
 }
 
 class UnlinkedExport {
   String _uri;
   List<UnlinkedCombinator> _combinators;
 
   UnlinkedExport.fromJson(Map json)
     : _uri = json["uri"],
       _combinators = json["combinators"]?.map((x) => new UnlinkedCombinator.fromJson(x))?.toList();
@@ skipping 749 matching lines @@
   UnlinkedVariableBuilder builder = new UnlinkedVariableBuilder(builderContext);
   builder.name = name;
   builder.type = type;
   builder.isStatic = isStatic;
   builder.isFinal = isFinal;
   builder.isConst = isConst;
   builder.hasImplicitType = hasImplicitType;
   return builder;
 }