Source/core/dom/PresentationAttributeStyle.cpp - Issue 152883002: (Concept patch) Simplify WTF::HashTable::add() return value for size and performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/PresentationAttributeStyle.cpp

Issue 152883002: (Concept patch) Simplify WTF::HashTable::add() return value for size and performance (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/CSSSegmentedFontFace.cpp ('K') | « Source/core/dom/DocumentSharedObjectPool.cpp ('k') | Source/core/dom/custom/CustomElementScheduler.cpp » ('j') | Source/core/dom/custom/CustomElementScheduler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/PresentationAttributeStyle.cpp

diff --git a/Source/core/dom/PresentationAttributeStyle.cpp b/Source/core/dom/PresentationAttributeStyle.cpp

index e9ced659b2953d6550d27521016435fe4059a63d..18b0e36afb62be75985c3bca48fa4c4a161107c9 100644

--- a/Source/core/dom/PresentationAttributeStyle.cpp

+++ b/Source/core/dom/PresentationAttributeStyle.cpp

@@ -163,13 +163,13 @@ PassRefPtr<StylePropertySet> computePresentationAttributeStyle(Element& element)

unsigned cacheHash = computePresentationAttributeCacheHash(cacheKey);

- PresentationAttributeCache::iterator cacheIterator;

+ PresentationAttributeCache::ValueType* cacheIterator;

Erik Corry 2014/02/04 14:27:15 It seems wrong to call this 'iterator'.

if (cacheHash) {

cacheIterator = presentationAttributeCache().add(cacheHash, nullptr).iterator;

if (cacheIterator->value && cacheIterator->value->key != cacheKey)

cacheHash = 0;

} else {

- cacheIterator = presentationAttributeCache().end();

+ cacheIterator = 0;

}

RefPtr<StylePropertySet> style;