Issue 1528693002: Fix an NPE in location bar suggestion showing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1528693002: Fix an NPE in location bar suggestion showing. (Closed)

Created:
5 years ago by Ted C

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

Fix an NPE in location bar suggestion showing. Ensure the suggestion list container is initialized before attempting to add things to it. BUG=565113 Review URL: https://codereview.chromium.org/1516273004 Cr-Commit-Position: refs/heads/master@{#364886} Committed: https://chromium.googlesource.com/chromium/src/+/0d208d9e8c1cfb2ab88599bf7b34364e5ff1abdd

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -20 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java	View		2 chunks	+28 lines, -20 lines	0 comments	Download

Total messages: 2 (1 generated)

Ted C

5 years ago (2015-12-14 22:21:52 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0d208d9e8c1cfb2ab88599bf7b34364e5ff1abdd.