Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1516273004: Fix an NPE in location bar suggestion showing. (Closed)

Created:
5 years ago by Ted C
Modified:
5 years ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an NPE in location bar suggestion showing. Ensure the suggestion list container is initialized before attempting to add things to it. BUG=565113 Committed: https://crrev.com/5d95d157d0e909bd82aa226e64a3f2011d6e17f8 Cr-Commit-Position: refs/heads/master@{#364886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -20 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 2 chunks +28 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Ted C
PTAL
5 years ago (2015-12-11 21:58:32 UTC) #2
newt (away)
lgtm Any idea what order of events causes this NPE?
5 years ago (2015-12-11 22:43:59 UTC) #3
Ted C
On 2015/12/11 22:43:59, newt wrote: > lgtm > > Any idea what order of events ...
5 years ago (2015-12-11 23:22:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516273004/1
5 years ago (2015-12-12 00:20:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
5 years ago (2015-12-12 02:26:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516273004/1
5 years ago (2015-12-12 02:51:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-12 03:44:42 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-12 03:46:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d95d157d0e909bd82aa226e64a3f2011d6e17f8
Cr-Commit-Position: refs/heads/master@{#364886}

Powered by Google App Engine
This is Rietveld 408576698