Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 1528653002: Revert of Plugin Power Saver: Improve Poster behavior for essential plugins. (Closed)

Created:
5 years ago by jam
Modified:
5 years ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Plugin Power Saver: Improve Poster behavior for essential plugins. (patchset #8 id:140001 of https://codereview.chromium.org/1497623002/ ) Reason for revert: Causing lots of flakiness in PrerenderBrowserTest.PrerenderContentSettingDetect BUG=569198 Original issue's description: > Plugin Power Saver: Improve Poster behavior for essential plugins. > > This patch does two things: > > 1) Early exit plugin placeholder if the poster-specified plugin is > same-origin or whitelisted-origin. The placeholder is never created. > > 2) Fix bug that made the poster geometry recheck flaky. This fixes one > bug, but there may be more. The geometry recheck logic is super janky. > > BUG=560590 > > Committed: https://crrev.com/fa5a32e29048ba0be1cbed8221fb74b7731dc55e > Cr-Commit-Position: refs/heads/master@{#364781} TBR=groby@chromium.org,piman@chromium.org,thestig@chromium.org,tommycli@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=560590 Committed: https://crrev.com/9bbcff19095d8b25342e29fa1e66c8d5c18d95d3 Cr-Commit-Position: refs/heads/master@{#365065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -396 lines) Patch
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 5 chunks +99 lines, -20 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.h View 2 chunks +18 lines, -2 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.cc View 3 chunks +9 lines, -15 lines 0 comments Download
M chrome/renderer/plugins/plugin_preroller.cc View 2 chunks +5 lines, -6 lines 0 comments Download
D chrome/renderer/plugins/power_saver_info.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/renderer/plugins/power_saver_info.cc View 1 chunk +0 lines, -124 lines 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M content/public/renderer/render_frame.h View 4 chunks +10 lines, -25 lines 0 comments Download
M content/renderer/pepper/plugin_instance_throttler_impl.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M content/renderer/pepper/plugin_power_saver_helper.h View 2 chunks +5 lines, -9 lines 0 comments Download
M content/renderer/pepper/plugin_power_saver_helper.cc View 2 chunks +20 lines, -16 lines 0 comments Download
M content/renderer/pepper/plugin_power_saver_helper_browsertest.cc View 3 chunks +89 lines, -18 lines 0 comments Download
M content/renderer/peripheral_content_heuristic.h View 2 chunks +18 lines, -10 lines 0 comments Download
M content/renderer/peripheral_content_heuristic.cc View 2 chunks +14 lines, -20 lines 0 comments Download
M content/renderer/peripheral_content_heuristic_unittest.cc View 2 chunks +35 lines, -48 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +5 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jam
Created Revert of Plugin Power Saver: Improve Poster behavior for essential plugins.
5 years ago (2015-12-14 19:17:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528653002/1
5 years ago (2015-12-14 19:17:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 19:21:01 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-14 19:22:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bbcff19095d8b25342e29fa1e66c8d5c18d95d3
Cr-Commit-Position: refs/heads/master@{#365065}

Powered by Google App Engine
This is Rietveld 408576698