Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2919)

Unified Diff: chrome/renderer/plugins/chrome_plugin_placeholder.cc

Issue 1528653002: Revert of Plugin Power Saver: Improve Poster behavior for essential plugins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/plugins/chrome_plugin_placeholder.h ('k') | chrome/renderer/plugins/plugin_preroller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/plugins/chrome_plugin_placeholder.cc
diff --git a/chrome/renderer/plugins/chrome_plugin_placeholder.cc b/chrome/renderer/plugins/chrome_plugin_placeholder.cc
index 61b7a70bd6b3f92cced33a6cdc7e9b429461dcda..56565bdd1b56d261de0106968d5c143793c367c2 100644
--- a/chrome/renderer/plugins/chrome_plugin_placeholder.cc
+++ b/chrome/renderer/plugins/chrome_plugin_placeholder.cc
@@ -110,7 +110,7 @@
const base::string16& name,
int template_id,
const base::string16& message,
- const PowerSaverInfo& power_saver_info) {
+ const PlaceholderPosterInfo& poster_info) {
base::DictionaryValue values;
values.SetString("message", message);
values.SetString("name", name);
@@ -121,17 +121,16 @@
? "document"
: "embedded");
- if (!power_saver_info.poster_attribute.empty()) {
- values.SetString("poster", power_saver_info.poster_attribute);
- values.SetString("baseurl", power_saver_info.base_url.spec());
-
- if (!power_saver_info.custom_poster_size.IsEmpty()) {
+ if (!poster_info.poster_attribute.empty()) {
+ values.SetString("poster", poster_info.poster_attribute);
+ values.SetString("baseurl", poster_info.base_url.spec());
+
+ if (!poster_info.custom_poster_size.IsEmpty()) {
float zoom_factor =
blink::WebView::zoomLevelToZoomFactor(frame->view()->zoomLevel());
- int width =
- roundf(power_saver_info.custom_poster_size.width() / zoom_factor);
+ int width = roundf(poster_info.custom_poster_size.width() / zoom_factor);
int height =
- roundf(power_saver_info.custom_poster_size.height() / zoom_factor);
+ roundf(poster_info.custom_poster_size.height() / zoom_factor);
values.SetString("visibleWidth", base::IntToString(width) + "px");
values.SetString("visibleHeight", base::IntToString(height) + "px");
}
@@ -148,15 +147,10 @@
ChromePluginPlaceholder* blocked_plugin = new ChromePluginPlaceholder(
render_frame, frame, params, html_data, name);
- if (!power_saver_info.poster_attribute.empty())
+ if (!poster_info.poster_attribute.empty())
blocked_plugin->BlockForPowerSaverPoster();
blocked_plugin->SetPluginInfo(info);
blocked_plugin->SetIdentifier(identifier);
-
- blocked_plugin->set_power_saver_enabled(power_saver_info.power_saver_enabled);
- blocked_plugin->set_blocked_for_background_tab(
- power_saver_info.blocked_for_background_tab);
-
return blocked_plugin;
}
« no previous file with comments | « chrome/renderer/plugins/chrome_plugin_placeholder.h ('k') | chrome/renderer/plugins/plugin_preroller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698