Oilpan: make ScrollableAreaTest.ScrollbarTrackAndThumbRepaint work.

Oilpan: make ScrollableAreaTest.ScrollbarTrackAndThumbRepaint work.

Scrollbars assume that their associated theme objects live longer,
unregistering themselves upon finalization.

Make it clear that this lifetime assumption must also hold for Scrollbars
created by the test-only constructor Scrollbar::createForTesting() +
alter ScrollableAreaTest.ScrollbarTrackAndThumbRepaint so that the
scrollbars it creates are finalized before the mock theme object is.
With Oilpan, explicit flushing out of garbage is needed.

R=haraken
BUG=549277
Committed: https://crrev.com/49c0e168ac8e30ea0d491481b30d37932a79c723
Cr-Commit-Position: refs/heads/master@{#365517}

[sof, 2015-12-16 08:33:26]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-12-16 08:33:27]

please take a look.

[haraken, 2015-12-16 08:34:55]

LGTM

[sof, 2015-12-16 08:37:10]

Description was changed from

==========
Oilpan: make ScrollableAreaTest.ScrollbarTrackAndThumbRepaint work.

Scrollbars assume that their associated theme objects live longer,
unregistering themselves upon finalization.

Make it clear that this lifetime assumption must also hold for Scrollbars
created by the test-only constructor Scrollbar::createForTesting() +
alter ScrollableAreaTest.ScrollbarTrackAndThumbRepaint so that the
scrollbars it creates are finalized before the mock theme object is.
With Oilpan, explicit flushing out of garbage is needed.

R=
BUG=549277
==========

to

==========
Oilpan: make ScrollableAreaTest.ScrollbarTrackAndThumbRepaint work.

Scrollbars assume that their associated theme objects live longer,
unregistering themselves upon finalization.

Make it clear that this lifetime assumption must also hold for Scrollbars
created by the test-only constructor Scrollbar::createForTesting() +
alter ScrollableAreaTest.ScrollbarTrackAndThumbRepaint so that the
scrollbars it creates are finalized before the mock theme object is.
With Oilpan, explicit flushing out of garbage is needed.

R=haraken
BUG=549277
==========

[sof, 2015-12-16 08:37:13]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-12-16 08:37:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528613006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528613006/1

[commit-bot: I haz the power, 2015-12-16 11:40:52]

Description was changed from

==========
Oilpan: make ScrollableAreaTest.ScrollbarTrackAndThumbRepaint work.

Scrollbars assume that their associated theme objects live longer,
unregistering themselves upon finalization.

Make it clear that this lifetime assumption must also hold for Scrollbars
created by the test-only constructor Scrollbar::createForTesting() +
alter ScrollableAreaTest.ScrollbarTrackAndThumbRepaint so that the
scrollbars it creates are finalized before the mock theme object is.
With Oilpan, explicit flushing out of garbage is needed.

R=haraken
BUG=549277
==========

to

==========
Oilpan: make ScrollableAreaTest.ScrollbarTrackAndThumbRepaint work.

Scrollbars assume that their associated theme objects live longer,
unregistering themselves upon finalization.

Make it clear that this lifetime assumption must also hold for Scrollbars
created by the test-only constructor Scrollbar::createForTesting() +
alter ScrollableAreaTest.ScrollbarTrackAndThumbRepaint so that the
scrollbars it creates are finalized before the mock theme object is.
With Oilpan, explicit flushing out of garbage is needed.

R=haraken
BUG=549277
==========

[commit-bot: I haz the power, 2015-12-16 11:40:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-16 11:41:45]

Description was changed from

==========
Oilpan: make ScrollableAreaTest.ScrollbarTrackAndThumbRepaint work.

Scrollbars assume that their associated theme objects live longer,
unregistering themselves upon finalization.

Make it clear that this lifetime assumption must also hold for Scrollbars
created by the test-only constructor Scrollbar::createForTesting() +
alter ScrollableAreaTest.ScrollbarTrackAndThumbRepaint so that the
scrollbars it creates are finalized before the mock theme object is.
With Oilpan, explicit flushing out of garbage is needed.

R=haraken
BUG=549277
==========

to

==========
Oilpan: make ScrollableAreaTest.ScrollbarTrackAndThumbRepaint work.

Scrollbars assume that their associated theme objects live longer,
unregistering themselves upon finalization.

Make it clear that this lifetime assumption must also hold for Scrollbars
created by the test-only constructor Scrollbar::createForTesting() +
alter ScrollableAreaTest.ScrollbarTrackAndThumbRepaint so that the
scrollbars it creates are finalized before the mock theme object is.
With Oilpan, explicit flushing out of garbage is needed.

R=haraken
BUG=549277

Committed: https://crrev.com/49c0e168ac8e30ea0d491481b30d37932a79c723
Cr-Commit-Position: refs/heads/master@{#365517}
==========

[commit-bot: I haz the power, 2015-12-16 11:41:46]

Patchset 1 (id:??) landed as
https://crrev.com/49c0e168ac8e30ea0d491481b30d37932a79c723
Cr-Commit-Position: refs/heads/master@{#365517}

[jbroman, 2015-12-16 12:18:11]

jbroman@chromium.org changed reviewers:
+ haraken@chromium.org, jbroman@chromium.org

[jbroman, 2015-12-16 12:18:12]

https://codereview.chromium.org/1528613006/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp (right):

https://codereview.chromium.org/1528613006/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp:181:
Heap::collectAllGarbage();
The object in question still has a RawPtr<Scrollbar> in scope; is this
guaranteed to work?

[sof, 2015-12-16 12:20:38]

https://codereview.chromium.org/1528613006/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp (right):

https://codereview.chromium.org/1528613006/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp:181:
Heap::collectAllGarbage();
On 2015/12/16 12:18:12, jbroman wrote:
> The object in question still has a RawPtr<Scrollbar> in scope; is this
> guaranteed to work?

The GCs performed by this are precise (non-conservative), so none of the objects
created in this test will be reachable. => they'll be swept out, as wanted.