third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp - Issue 1528613006: Oilpan: make ScrollableAreaTest.ScrollbarTrackAndThumbRepaint work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp

Issue 1528613006: Oilpan: make ScrollableAreaTest.ScrollbarTrackAndThumbRepaint work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp b/third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp

index 52885bb7473c89ef3a5b90d793d020b974ffafb1..c71f4ac5af43cd37a954b9a8318ea9fa213e1884 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp

@@ -176,6 +176,9 @@ TEST_F(ScrollableAreaTest, ScrollbarTrackAndThumbRepaint)

scrollbar->setNeedsPaintInvalidation();

EXPECT_FALSE(scrollbar->trackNeedsRepaint());

EXPECT_FALSE(scrollbar->thumbNeedsRepaint());

+ // Forced GC in order to finalize objects depending on the mock object.

+ Heap::collectAllGarbage();

jbroman 2015/12/16 12:18:12 The object in question still has a RawPtr<Scrollba

sof 2015/12/16 12:20:38 The GCs performed by this are precise (non-conserv

}

class MockGraphicsLayerClient : public GraphicsLayerClient {

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/scroll/Scrollbar.h » ('j') | no next file with comments »