adb_wait_for_device: Add battery fallback, support no battery

adb_wait_for_device: Add battery fallback, support no battery

BUG=skia:4690
TBR=rmistry

Committed: https://skia.googlesource.com/skia/+/c9730831fcff6016279b304f246740b3cf53f9e4

[borenet, 2015-12-14 17:51:31]

borenet@google.com changed reviewers:
+ rmistry@google.com

[borenet, 2015-12-14 17:52:12]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2015-12-14 17:52:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528563002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528563002/1

[commit-bot: I haz the power, 2015-12-14 17:52:22]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-12-14 23:52 UTC

[borenet, 2015-12-14 18:06:27]

Description was changed from

==========
adb_wait_for_device: Add battery fallback, support no battery

BUG=skia:4690
==========

to

==========
adb_wait_for_device: Add battery fallback, support no battery

BUG=skia:4690
TBR=rmistry
==========

[borenet, 2015-12-14 18:06:45]

On 2015/12/14 17:52:22, commit-bot: I haz the power wrote:
> Note for Reviewers:
> The CQ is waiting for an approval.
> If you believe that the CL is not ready yet, or if you would like to L-G-T-M
> with comments then please uncheck the CQ checkbox.
> 
> Waiting for LGTM from valid reviewer(s) till 2015-12-14 23:52 UTC

TBRing since this is important.  Will respond to any comments in a subsequent
CL.

[borenet, 2015-12-14 18:06:48]

The CQ bit was unchecked by borenet@google.com

[borenet, 2015-12-14 18:06:52]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2015-12-14 18:07:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528563002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528563002/1

[commit-bot: I haz the power, 2015-12-14 18:07:39]

Description was changed from

==========
adb_wait_for_device: Add battery fallback, support no battery

BUG=skia:4690
TBR=rmistry
==========

to

==========
adb_wait_for_device: Add battery fallback, support no battery

BUG=skia:4690
TBR=rmistry

Committed:
https://skia.googlesource.com/skia/+/c9730831fcff6016279b304f246740b3cf53f9e4
==========

[commit-bot: I haz the power, 2015-12-14 18:07:40]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c9730831fcff6016279b304f246740b3cf53f9e4

[rmistry, 2015-12-14 18:16:09]

lgtm

Minor comment for the next time you touch this file.

https://codereview.chromium.org/1528563002/diff/1/platform_tools/android/bin/...
File platform_tools/android/bin/adb_wait_for_device (right):

https://codereview.chromium.org/1528563002/diff/1/platform_tools/android/bin/...
platform_tools/android/bin/adb_wait_for_device:9: function _get_battery_level {
Maybe better name is parse_battery_level (or something similar).
Also add some documentation about what this function does.

[borenet, 2015-12-14 18:26:31]

https://codereview.chromium.org/1528563002/diff/1/platform_tools/android/bin/...
File platform_tools/android/bin/adb_wait_for_device (right):

https://codereview.chromium.org/1528563002/diff/1/platform_tools/android/bin/...
platform_tools/android/bin/adb_wait_for_device:9: function _get_battery_level {
On 2015/12/14 18:16:09, rmistry wrote:
> Maybe better name is parse_battery_level (or something similar).
> Also add some documentation about what this function does.

Done in https://codereview.chromium.org/1527713002