Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1527713002: adb_wait_for_device: More fixes (Closed)

Created:
5 years ago by borenet
Modified:
5 years ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M platform_tools/android/bin/adb_wait_for_device View 1 4 chunks +7 lines, -4 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
borenet
https://codereview.chromium.org/1527713002/diff/20001/platform_tools/android/bin/adb_wait_for_device File platform_tools/android/bin/adb_wait_for_device (right): https://codereview.chromium.org/1527713002/diff/20001/platform_tools/android/bin/adb_wait_for_device#newcode23 platform_tools/android/bin/adb_wait_for_device:23: if [ "$PRESENT" = "0" ]; then Prevents error ...
5 years ago (2015-12-14 18:26:24 UTC) #2
rmistry
lgtm
5 years ago (2015-12-14 20:55:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527713002/20001
5 years ago (2015-12-15 12:11:58 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-15 12:25:46 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f64be4466793280a07ad4aa2319efe152d0e455d

Powered by Google App Engine
This is Rietveld 408576698