Implement plumbing for variations in feedback reports.

Report variations in Android feedback reports.

This CL Makes the Chrome for Android feedback report mechanism
include Google web property-visible variation ids as part of the
report. This matches what's sent up by the components/feedback
implementation that's used on other platforms.

The cross-platform implementation of sending variation ids is
done in feedback_uploader_chrome.cc via the call to
VariationsHttpHeaderProvider::AppendHeaders.

BUG=530223
Committed: https://crrev.com/35ba64798a399dd4eedd637583e26a01a90b8a23
Cr-Commit-Position: refs/heads/master@{#366219}

[Alexei Svitkine (slow), 2015-12-14 22:30:23]

Patchset #1 (id:1) has been deleted

[Alexei Svitkine (slow), 2015-12-14 22:30:29]

Patchset #1 (id:20001) has been deleted

[Alexei Svitkine (slow), 2015-12-14 22:30:35]

Patchset #1 (id:40001) has been deleted

[Alexei Svitkine (slow), 2015-12-14 22:33:33]

Description was changed from

==========
Implement plumbing for variations in feedback reports.

BUG=...
==========

to

==========
Report variations in Android feedback reports.

This CL expands the Chrome for Android feedback report mechanism
to include Google web property-visible variation ids as part of the
report. This matches what's sent up by the components/feedback
implementation that's used on other platforms.

BUG=530223
==========

[Alexei Svitkine (slow), 2015-12-14 22:35:33]

Description was changed from

==========
Report variations in Android feedback reports.

This CL expands the Chrome for Android feedback report mechanism
to include Google web property-visible variation ids as part of the
report. This matches what's sent up by the components/feedback
implementation that's used on other platforms.

BUG=530223
==========

to

==========
Report variations in Android feedback reports.

This CL expands the Chrome for Android feedback report mechanism
to include Google web property-visible variation ids as part of the
report. This matches what's sent up by the components/feedback
implementation that's used on other platforms (see the
VariationsHttpHeaderProvider::AppendHeaders call in
feedback_uploader_chrome.cc).

BUG=530223
==========

[Alexei Svitkine (slow), 2015-12-14 22:37:54]

Description was changed from

==========
Report variations in Android feedback reports.

This CL expands the Chrome for Android feedback report mechanism
to include Google web property-visible variation ids as part of the
report. This matches what's sent up by the components/feedback
implementation that's used on other platforms (see the
VariationsHttpHeaderProvider::AppendHeaders call in
feedback_uploader_chrome.cc).

BUG=530223
==========

to

==========
Report variations in Android feedback reports.

This CL Makes the Chrome for Android feedback report mechanism
include Google web property-visible variation ids as part of the
report. This matches what's sent up by the components/feedback
implementation that's used on other platforms.

The cross-platform implementation of sending variation ids is
done in feedback_uploader_chrome.cc via the call to
VariationsHttpHeaderProvider::AppendHeaders.

BUG=530223
==========

[Alexei Svitkine (slow), 2015-12-14 22:39:32]

asvitkine@chromium.org changed reviewers:
+ jwd@chromium.org, nyquist@chromium.org

[Alexei Svitkine (slow), 2015-12-14 22:39:32]

jwd: Please review the variations parts.
nyquest: Please review the Java parts.

I still need to test this manually (to see if the data actually gets into the
report), which I plan to do tomorrow or later next week. Will not submit until
I've confirmed that it's working, but seems like it should.

[jwd, 2015-12-16 22:22:22]

Variations LGTM

[Alexei Svitkine (slow), 2015-12-16 22:25:25]

Looks like there's a DEPS issue I need to resolve.
variations_http_header_provider.cc
is in a separate target that variations_associated_data_android.cc doesn't
depend on. I'll ping the CL once I've resolved that.

On Wed, Dec 16, 2015 at 5:22 PM, <jwd@chromium.org> wrote:

> Variations LGTM
>
> https://codereview.chromium.org/1528543003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nyquist, 2015-12-16 23:47:32]

java parts lgtm

[Alexei Svitkine (slow), 2015-12-17 20:43:50]

As an update, I'm going to land a separate CL that moves
variations_http_header_provider.cc
up to components/variations from components/variations/net that will
resolve this CL's DEPS issue. Once that lands, I'll rebase this CL on that
and it should be good to land.

On Wed, Dec 16, 2015 at 6:47 PM, <nyquist@chromium.org> wrote:

> java parts lgtm
>
> https://codereview.chromium.org/1528543003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexei Svitkine (slow), 2015-12-18 19:41:09]

Patchset #2 (id:80001) has been deleted

[Alexei Svitkine (slow), 2015-12-18 19:43:31]

Rebased on top of https://codereview.chromium.org/1530133005/

[Alexei Svitkine (slow), 2015-12-18 22:40:43]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-12-18 22:40:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/1528543003/#ps120001
(title: "Re-add function that was lost in a rebase.")

[commit-bot: I haz the power, 2015-12-18 22:40:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528543003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528543003/120001

[commit-bot: I haz the power, 2015-12-18 23:52:39]

Description was changed from

==========
Report variations in Android feedback reports.

This CL Makes the Chrome for Android feedback report mechanism
include Google web property-visible variation ids as part of the
report. This matches what's sent up by the components/feedback
implementation that's used on other platforms.

The cross-platform implementation of sending variation ids is
done in feedback_uploader_chrome.cc via the call to
VariationsHttpHeaderProvider::AppendHeaders.

BUG=530223
==========

to

==========
Report variations in Android feedback reports.

This CL Makes the Chrome for Android feedback report mechanism
include Google web property-visible variation ids as part of the
report. This matches what's sent up by the components/feedback
implementation that's used on other platforms.

The cross-platform implementation of sending variation ids is
done in feedback_uploader_chrome.cc via the call to
VariationsHttpHeaderProvider::AppendHeaders.

BUG=530223
==========

[commit-bot: I haz the power, 2015-12-18 23:52:40]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2015-12-18 23:53:22]

Description was changed from

==========
Report variations in Android feedback reports.

This CL Makes the Chrome for Android feedback report mechanism
include Google web property-visible variation ids as part of the
report. This matches what's sent up by the components/feedback
implementation that's used on other platforms.

The cross-platform implementation of sending variation ids is
done in feedback_uploader_chrome.cc via the call to
VariationsHttpHeaderProvider::AppendHeaders.

BUG=530223
==========

to

==========
Report variations in Android feedback reports.

This CL Makes the Chrome for Android feedback report mechanism
include Google web property-visible variation ids as part of the
report. This matches what's sent up by the components/feedback
implementation that's used on other platforms.

The cross-platform implementation of sending variation ids is
done in feedback_uploader_chrome.cc via the call to
VariationsHttpHeaderProvider::AppendHeaders.

BUG=530223

Committed: https://crrev.com/35ba64798a399dd4eedd637583e26a01a90b8a23
Cr-Commit-Position: refs/heads/master@{#366219}
==========

[commit-bot: I haz the power, 2015-12-18 23:53:23]

Patchset 3 (id:??) landed as
https://crrev.com/35ba64798a399dd4eedd637583e26a01a90b8a23
Cr-Commit-Position: refs/heads/master@{#366219}