Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java

Issue 1528543003: Implement plumbing for variations in feedback reports. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re-add function that was lost in a rebase. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/variations/android/java/src/org/chromium/components/variations/VariationsAssociatedData.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java b/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
index 5d9f6c6184cb60378ce7c4b6fd2299b5d55d1d00..218a166a328ef7129fee36dc40e715ea0b5695ef 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
@@ -14,6 +14,7 @@ import org.chromium.base.ThreadUtils;
import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;
import org.chromium.chrome.browser.profiles.Profile;
+import org.chromium.components.variations.VariationsAssociatedData;
import java.util.HashMap;
import java.util.Map;
@@ -238,6 +239,7 @@ public class FeedbackCollector
addUrl();
addConnectivityData();
addDataReductionProxyData();
+ addVariationsData();
return asBundle();
}
@@ -260,6 +262,11 @@ public class FeedbackCollector
mData.putAll(dataReductionProxyMap);
}
+ private void addVariationsData() {
+ if (mProfile.isOffTheRecord()) return;
+ mData.putAll(VariationsAssociatedData.getFeedbackMap());
+ }
+
private Bundle asBundle() {
Bundle bundle = new Bundle();
for (Map.Entry<String, String> entry : mData.entrySet()) {
« no previous file with comments | « no previous file | components/variations/android/java/src/org/chromium/components/variations/VariationsAssociatedData.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698