Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1528413002: Subzero. ARM32. Fixes register aliasing bugs. (Closed)

Created:
5 years ago by John
Modified:
5 years ago
Reviewers:
Jim Stichnoth, Karl, sehr
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M pydir/gen_arm32_reg_tables.py View 4 chunks +4 lines, -5 lines 0 comments Download
M src/IceRegistersARM32.def View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
John
5 years ago (2015-12-16 17:04:28 UTC) #2
Karl
lgtm
5 years ago (2015-12-16 17:21:52 UTC) #3
John
Committed patchset #1 (id:1) manually as c628b6809d88bb12e78be7d535c66bf439385b4b (presubmit successful).
5 years ago (2015-12-16 17:52:15 UTC) #5
Jim Stichnoth
5 years ago (2015-12-16 18:10:43 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698