Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1528183004: Revert of Response construction with a ReadableStream (Closed)

Created:
5 years ago by Yuta Kitamura
Modified:
5 years ago
CC:
domenic, blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Response construction with a ReadableStream (patchset #14 id:340001 of https://codereview.chromium.org/1506023003/ ) Reason for revert: Seems to have broken leak bots: https://code.google.com/p/chromium/issues/detail?id=570168 Original issue's description: > Response construction with a ReadableStream > > This CL implements Response construction with a ReadableStream provided > by V8 Extras. The feature is behind a runtime enabled flag. > > The implementation is not perfect. > - ReadableStreamDataConsumerHandle should be thread-safe but is not. > - ReadableStreamDataConsumerHandle may cause memory leaks. > But these problems don't bother stable users. > > BUG=564479 > > Committed: https://crrev.com/6aa006ba0f0f8a60c20167ad009f5699e40b8ef2 > Cr-Commit-Position: refs/heads/master@{#364968} > > Committed: https://crrev.com/84d781133725f4170c0c21a99da1f35c9e17ca5d > Cr-Commit-Position: refs/heads/master@{#365229} TBR=domenic@chromium.org,bashi@google.com,bashi@chromium.org,haraken@chromium.org,tyoshino@chromium.org,yhirano@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=564479 Committed: https://crrev.com/95970b69597f4d8e6d947e9ace979036cfe9f532 Cr-Commit-Position: refs/heads/master@{#365425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1084 lines) Patch
D third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response-stream-construction.js View 1 chunk +0 lines, -96 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/response-stream-construction.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/response-stream-construction-base-https-other-https.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/fetch/window/response-stream-construction.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/fetch/window/response-stream-construction-base-https-other-https.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/fetch/workers/response-stream-construction.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/fetch/workers/response-stream-construction-base-https-other-https.html View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp View 2 chunks +19 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.h View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.h View 2 chunks +1 line, -2 lines 0 comments Download
D third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.h View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp View 1 chunk +0 lines, -280 lines 0 comments Download
D third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp View 1 chunk +0 lines, -441 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 3 chunks +25 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.idl View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Yuta Kitamura
Created Revert of Response construction with a ReadableStream
5 years ago (2015-12-16 03:42:41 UTC) #1
haraken
LGTM to revert
5 years ago (2015-12-16 03:44:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528183004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528183004/1
5 years ago (2015-12-16 03:46:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 03:51:53 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-16 03:53:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95970b69597f4d8e6d947e9ace979036cfe9f532
Cr-Commit-Position: refs/heads/master@{#365425}

Powered by Google App Engine
This is Rietveld 408576698