third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.h - Issue 1528183004: Revert of Response construction with a ReadableStream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.h

Issue 1528183004: Revert of Response construction with a ReadableStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.h b/third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.h

index 739ad0ad19ef1165669005adcf7c81bad9afd9a4..b857e574bf34ba8b7952e87897906e79206c5f8b 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.h

@@ -12,14 +12,7 @@

namespace blink {

-// "Iterator result" in this file is an object returned from iterator.next()

-// having two members "done" and "value".

CORE_EXPORT v8::Local<v8::Object> v8IteratorResultValue(v8::Isolate*, bool done, v8::Local<v8::Value>);

-// Unpacks |result|, stores the value of "done" member to |done| and returns

-// the value of "value" member. Returns an empty handle when errored.

-CORE_EXPORT v8::MaybeLocal<v8::Value> v8UnpackIteratorResult(ScriptState*, v8::Local<v8::Object> result, bool* done);

template<typename T>

inline ScriptValue v8IteratorResult(ScriptState* scriptState, const T& value)