Added 64 bit number support in the build gles2 command buffer script.

Added 64 bit number support in the build gles2 command buffer script.

All members in the command buffer structures need to be 32 bit aligned,
for this reason 64 bit numbers were not supported. I have added
functionality to convert 64 bit numbers into 2 separate fields. This
was previously done manually in some commands (glClientWaitSync,
glWaitSync) and broken in other commands that used 64 bit arguments
(glInsertFenceSyncCHROMIUM, glWaitSyncTokenCHROMIUM).

R=zmo@chromium.org
BUG=514815
Committed: https://crrev.com/04ff8e34fa897694907bb97e574905339e98de2d
Cr-Commit-Position: refs/heads/master@{#365407}

[David Yen, 2015-12-15 22:26:43]

On 2015/12/15 21:59:12, David Yen wrote:

I've changed my functions to use the conversion functions in GLES2Util and also
converted glWaitClientSync & glWaitSync to use GLuint64 instead of separating
out into 2 uint32 numbers manually. PTAL.

[David Yen, 2015-12-15 22:27:21]

Description was changed from

==========
Added 64 bit number support in the build gles2 command buffer script.

All members in the command buffer structures need to be 32 bit aligned,
for this reason 64 bit numbers were not supported. I have added
functionality to convert 64 bit numbers into 2 separate fields. This
was previously done manually in some commands (glClientWaitSync) and
broken in other commands that used 64 bit arguments in the command
buffer (glInsertFenceSyncCHROMIUM, glWaitSyncTokenCHROMIUM).

R=zmo@chromium.org
BUG=514815
==========

to

==========
Added 64 bit number support in the build gles2 command buffer script.

All members in the command buffer structures need to be 32 bit aligned,
for this reason 64 bit numbers were not supported. I have added
functionality to convert 64 bit numbers into 2 separate fields. This
was previously done manually in some commands (glClientWaitSync,
glWaitSync) and broken in other commands that used 64 bit arguments
(glInsertFenceSyncCHROMIUM, glWaitSyncTokenCHROMIUM).

R=zmo@chromium.org
BUG=514815
==========

[David Yen, 2015-12-15 22:27:54]

Description was changed from

==========
Added 64 bit number support in the build gles2 command buffer script.

All members in the command buffer structures need to be 32 bit aligned,
for this reason 64 bit numbers were not supported. I have added
functionality to convert 64 bit numbers into 2 separate fields. This
was previously done manually in some commands (glClientWaitSync,
glWaitSync) and broken in other commands that used 64 bit arguments
(glInsertFenceSyncCHROMIUM, glWaitSyncTokenCHROMIUM).

R=zmo@chromium.org
BUG=514815
==========

to

==========
Added 64 bit number support in the build gles2 command buffer script.

All members in the command buffer structures need to be 32 bit aligned,
for this reason 64 bit numbers were not supported. I have added
functionality to convert 64 bit numbers into 2 separate fields. This
was previously done manually in some commands (glClientWaitSync,
glWaitSync) and broken in other commands that used 64 bit arguments
(glInsertFenceSyncCHROMIUM, glWaitSyncTokenCHROMIUM).

R=zmo@chromium.org
BUG=514815
==========

[Zhenyao Mo, 2015-12-15 23:19:20]

lgtm

https://codereview.chromium.org/1528163002/diff/20001/gpu/command_buffer/buil...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/1528163002/diff/20001/gpu/command_buffer/buil...
gpu/command_buffer/build_gles2_cmd_buffer.py:3824: 'GLuint64 timeout',
Now it's the same original signature, we don't need to specify cmd_args at all.

[David Yen, 2015-12-15 23:20:31]

https://codereview.chromium.org/1528163002/diff/20001/gpu/command_buffer/buil...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/1528163002/diff/20001/gpu/command_buffer/buil...
gpu/command_buffer/build_gles2_cmd_buffer.py:3824: 'GLuint64 timeout',
On 2015/12/15 23:19:20, Zhenyao Mo wrote:
> Now it's the same original signature, we don't need to specify cmd_args at
all.

That's what I originally thought too, but actually the original signature for
the sync argument is GLSync.

[Zhenyao Mo, 2015-12-15 23:33:05]

On 2015/12/15 23:20:31, David Yen wrote:
>
https://codereview.chromium.org/1528163002/diff/20001/gpu/command_buffer/buil...
> File gpu/command_buffer/build_gles2_cmd_buffer.py (right):
> 
>
https://codereview.chromium.org/1528163002/diff/20001/gpu/command_buffer/buil...
> gpu/command_buffer/build_gles2_cmd_buffer.py:3824: 'GLuint64 timeout',
> On 2015/12/15 23:19:20, Zhenyao Mo wrote:
> > Now it's the same original signature, we don't need to specify cmd_args at
> all.
> 
> That's what I originally thought too, but actually the original signature for
> the sync argument is GLSync.

OK, then it is good as is.

[David Yen, 2015-12-15 23:34:18]

The CQ bit was checked by dyen@chromium.org

[commit-bot: I haz the power, 2015-12-15 23:37:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528163002/20001

[commit-bot: I haz the power, 2015-12-16 00:41:45]

Description was changed from

==========
Added 64 bit number support in the build gles2 command buffer script.

All members in the command buffer structures need to be 32 bit aligned,
for this reason 64 bit numbers were not supported. I have added
functionality to convert 64 bit numbers into 2 separate fields. This
was previously done manually in some commands (glClientWaitSync,
glWaitSync) and broken in other commands that used 64 bit arguments
(glInsertFenceSyncCHROMIUM, glWaitSyncTokenCHROMIUM).

R=zmo@chromium.org
BUG=514815
==========

to

==========
Added 64 bit number support in the build gles2 command buffer script.

All members in the command buffer structures need to be 32 bit aligned,
for this reason 64 bit numbers were not supported. I have added
functionality to convert 64 bit numbers into 2 separate fields. This
was previously done manually in some commands (glClientWaitSync,
glWaitSync) and broken in other commands that used 64 bit arguments
(glInsertFenceSyncCHROMIUM, glWaitSyncTokenCHROMIUM).

R=zmo@chromium.org
BUG=514815
==========

[commit-bot: I haz the power, 2015-12-16 00:41:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-16 00:43:21]

Description was changed from

==========
Added 64 bit number support in the build gles2 command buffer script.

All members in the command buffer structures need to be 32 bit aligned,
for this reason 64 bit numbers were not supported. I have added
functionality to convert 64 bit numbers into 2 separate fields. This
was previously done manually in some commands (glClientWaitSync,
glWaitSync) and broken in other commands that used 64 bit arguments
(glInsertFenceSyncCHROMIUM, glWaitSyncTokenCHROMIUM).

R=zmo@chromium.org
BUG=514815
==========

to

==========
Added 64 bit number support in the build gles2 command buffer script.

All members in the command buffer structures need to be 32 bit aligned,
for this reason 64 bit numbers were not supported. I have added
functionality to convert 64 bit numbers into 2 separate fields. This
was previously done manually in some commands (glClientWaitSync,
glWaitSync) and broken in other commands that used 64 bit arguments
(glInsertFenceSyncCHROMIUM, glWaitSyncTokenCHROMIUM).

R=zmo@chromium.org
BUG=514815

Committed: https://crrev.com/04ff8e34fa897694907bb97e574905339e98de2d
Cr-Commit-Position: refs/heads/master@{#365407}
==========

[commit-bot: I haz the power, 2015-12-16 00:43:22]

Patchset 2 (id:??) landed as
https://crrev.com/04ff8e34fa897694907bb97e574905339e98de2d
Cr-Commit-Position: refs/heads/master@{#365407}