Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: base/trace_event/etw_manifest/BUILD.gn

Issue 1528093003: Disable etw_manifest in the GN Windows build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/etw_manifest/BUILD.gn
diff --git a/base/trace_event/etw_manifest/BUILD.gn b/base/trace_event/etw_manifest/BUILD.gn
index ed83aab0ed4fdb956de24d592e0113c02798bb0d..73d771cef99facdc6ca5daf8407f3bbd0810b0af 100644
--- a/base/trace_event/etw_manifest/BUILD.gn
+++ b/base/trace_event/etw_manifest/BUILD.gn
@@ -6,15 +6,23 @@ import("//build/win/message_compiler.gni")
assert(is_win, "This only runs on Windows.")
-message_compiler("chrome_events_win") {
- visibility = [
- "//base/trace_event/*",
- "//chrome:main_dll",
- ]
+# TOOD(brucedawson) bug 569989: Enable ETW manifest and link it into the
+# proper places. Enabling as-is may add this to too many targets. See the bug
+# for more information.
+if (true) {
+ group("chrome_events_win") {
+ }
+} else {
+ message_compiler("chrome_events_win") {
brucedawson 2015/12/15 19:32:54 Does this control the linking of the .rc/.bin file
brettw 2015/12/16 19:19:09 Good catch! This would have been super annoying to
+ visibility = [
+ "//base/trace_event/*",
+ "//chrome:main_dll",
+ ]
- sources = [
- "chrome_events_win.man",
- ]
+ sources = [
+ "chrome_events_win.man",
+ ]
- user_mode_logging = true
+ user_mode_logging = true
+ }
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698