Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1527843002: infra_libs/logs: Check if log directory exists. (Closed)

Created:
5 years ago by dnj
Modified:
5 years ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

infra_libs/logs: Check if log directory exists. Check if a log directory exists before probing it and attempting to create a temporary file. This check prevents a condition being encountered on Windows 10 where E:\ is mapped to a removable disk and, consqeuently, the attempt to blindly create a file on it causes the script to hang pending removable media insertion. BUG=chromium:566094 TEST=local - Ran a test case on the afflicted system, hangs forever. - Applied fix, system works as expected. Committed: https://chromium.googlesource.com/infra/infra/+/da4c7862a6d9f7c2b7ac439852440e9de240bf27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M infra_libs/logs/logs.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dnj
PTAL
5 years ago (2015-12-14 23:26:08 UTC) #2
agable
lgtm
5 years ago (2015-12-14 23:46:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527843002/1
5 years ago (2015-12-14 23:52:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527843002/1
5 years ago (2015-12-14 23:58:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/infra/infra/+/da4c7862a6d9f7c2b7ac439852440e9de240bf27
5 years ago (2015-12-14 23:59:17 UTC) #10
kjellander_chromium
5 years ago (2015-12-15 06:48:09 UTC) #11
Message was sent while issue was closed.
LGTM! Thanks.

Powered by Google App Engine
This is Rietveld 408576698