infra_libs/logs/logs.py - Issue 1527843002: infra_libs/logs: Check if log directory exists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra_libs/logs/logs.py

Issue 1527843002: infra_libs/logs: Check if log directory exists. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: infra_libs/logs/logs.py

diff --git a/infra_libs/logs/logs.py b/infra_libs/logs/logs.py

index abd5165f908511a724e24561d464d7f528fb6445..2a32786d825f49164ea6ca0c515281d650b3f678 100644

--- a/infra_libs/logs/logs.py

+++ b/infra_libs/logs/logs.py

@@ -258,6 +258,9 @@ def _add_file_handlers(options, logger): # pragma: no cover

# running locally on developers' workstations.

logs_directory = tempfile.gettempdir()

for directory in options.logs_directory.split(os.pathsep):

+ if not os.path.isdir(directory):

+ continue

try:

with tempfile.TemporaryFile(dir=directory):

pass

« no previous file with comments | « no previous file | no next file » | no next file with comments »