[turbofan] Move replacements out of virtual object

[turbofan] Escape Analysis improvements

Move replacements out of virtual object. Replacements are
global to the graph and are not dependent on the virtual
state (after they are discovered).

R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n

Committed: https://crrev.com/4390514154949790943645d60674b99a6cef6897
Cr-Commit-Position: refs/heads/master@{#32838}

[sigurds, 2015-12-14 13:02:13]

I moved the replacements out of virtual objects. PTAL.

[sigurds, 2015-12-14 13:02:48]

Description was changed from

==========
[turbofan] Move replacements out of virtual object

Replacements are global to the graph and are not dependent
on the virtual state (after they are discovered).

R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n
==========

to

==========
[turbofan] Escape Analysis improvements

Move replacements out of virtual object. Replacements are
global to the graph and are not dependent on the virtual
state (after they are discovered).

R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n
==========

[Michael Starzinger, 2015-12-14 13:38:32]

LGTM with one suggestion.

https://codereview.chromium.org/1527533002/diff/80001/src/compiler/escape-ana...
File src/compiler/escape-analysis.h (right):

https://codereview.chromium.org/1527533002/diff/80001/src/compiler/escape-ana...
src/compiler/escape-analysis.h:110: Node* GetReplacement(NodeId id);
nit/suggestion: For the public interface it might make sense to pass in a
"Node*" instead of the "NodeId". The fact that node ids are used internally to
establish the mapping as an implementation detail. It also might make call-sites
slightly easier to read. WDYT? Both is fine with me, it's up to you.

[sigurds, 2015-12-14 13:48:00]

Thanks for the review!

https://codereview.chromium.org/1527533002/diff/80001/src/compiler/escape-ana...
File src/compiler/escape-analysis.h (right):

https://codereview.chromium.org/1527533002/diff/80001/src/compiler/escape-ana...
src/compiler/escape-analysis.h:110: Node* GetReplacement(NodeId id);
On 2015/12/14 13:38:32, Michael Starzinger wrote:
> nit/suggestion: For the public interface it might make sense to pass in a
> "Node*" instead of the "NodeId". The fact that node ids are used internally to
> establish the mapping as an implementation detail. It also might make
call-sites
> slightly easier to read. WDYT? Both is fine with me, it's up to you.

I agree, I changed the interface.

[sigurds, 2015-12-14 13:48:08]

The CQ bit was checked by sigurds@chromium.org

[sigurds, 2015-12-14 13:48:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1527533002/#ps100001
(title: "Address comment")

[commit-bot: I haz the power, 2015-12-14 13:48:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1527533002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1527533002/100001

[commit-bot: I haz the power, 2015-12-14 14:13:10]

Description was changed from

==========
[turbofan] Escape Analysis improvements

Move replacements out of virtual object. Replacements are
global to the graph and are not dependent on the virtual
state (after they are discovered).

R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n
==========

to

==========
[turbofan] Escape Analysis improvements

Move replacements out of virtual object. Replacements are
global to the graph and are not dependent on the virtual
state (after they are discovered).

R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n
==========

[commit-bot: I haz the power, 2015-12-14 14:13:10]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-12-14 14:13:40]

Description was changed from

==========
[turbofan] Escape Analysis improvements

Move replacements out of virtual object. Replacements are
global to the graph and are not dependent on the virtual
state (after they are discovered).

R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n
==========

to

==========
[turbofan] Escape Analysis improvements

Move replacements out of virtual object. Replacements are
global to the graph and are not dependent on the virtual
state (after they are discovered).

R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n

Committed: https://crrev.com/4390514154949790943645d60674b99a6cef6897
Cr-Commit-Position: refs/heads/master@{#32838}
==========

[commit-bot: I haz the power, 2015-12-14 14:13:41]

Patchset 6 (id:??) landed as
https://crrev.com/4390514154949790943645d60674b99a6cef6897
Cr-Commit-Position: refs/heads/master@{#32838}