bookmarks: Get rid of the dependency on history_notifications.h

chrome/browser/favicon/favicon_changed_details.h

Index: chrome/browser/favicon/favicon_changed_details.h
diff --git a/chrome/browser/favicon/favicon_changed_details.h b/chrome/browser/favicon/favicon_changed_details.h
new file mode 100644
index 0000000000000000000000000000000000000000..be7fc888b8cffb368e07d656c9878c3347afdbd9
--- /dev/null
+++ b/chrome/browser/favicon/favicon_changed_details.h
@@ -0,0 +1,24 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_FAVICON_FAVICON_CHANGED_DETAILS_H_
+#define CHROME_BROWSER_FAVICON_FAVICON_CHANGED_DETAILS_H_
+
+#include <set>
+
+#include "googleurl/src/gurl.h"
+
+namespace chrome {
+
+// Details for chrome::NOTIFICATION_FAVICON_CHANGED.
+struct FaviconChangedDetails {

[sky, 2013/05/20 14:48:13]

It seems as though favicons is always going to have a dependency on history.
Because of that I don't see the point in making this no longer extend
HistoryDetails.

[tfarina, 2013/05/20 23:10:30]

Yeah, I thought about this. I was not sure if including
chrome/browser/history/history_notifications.h here would be fine. I'll redo
this patch making FaviconChangedDetails inherit from HistoryDetails again, that
will greatly simplify this patch.

+  FaviconChangedDetails();
+  ~FaviconChangedDetails();
+
+  std::set<GURL> urls;
+};
+
+}  // namespace chrome
+
+#endif  // CHROME_BROWSER_FAVICON_FAVICON_CHANGED_DETAILS_H_