chrome/browser/favicon/favicon_changed_details.h - Issue 15275004: bookmarks: Get rid of the dependency on history_notifications.h

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/favicon/favicon_changed_details.h

Issue 15275004: bookmarks: Get rid of the dependency on history_notifications.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more android fixes Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_CHANGED_DETAILS_H_

	6 #define CHROME_BROWSER_FAVICON_FAVICON_CHANGED_DETAILS_H_

	7

	8 #include <set>

	9

	10 #include "googleurl/src/gurl.h"

	11

	12 namespace chrome {

	13

	14 // Details for chrome::NOTIFICATION_FAVICON_CHANGED.

	15 struct FaviconChangedDetails {
	sky 2013/05/20 14:48:13 It seems as though favicons is always going to hav It seems as though favicons is always going to have a dependency on history. Because of that I don't see the point in making this no longer extend HistoryDetails. tfarina 2013/05/20 23:10:30 Yeah, I thought about this. I was not sure if incl Show quoted text On 2013/05/20 14:48:13, sky wrote: > It seems as though favicons is always going to have a dependency on history. > Because of that I don't see the point in making this no longer extend > HistoryDetails. Yeah, I thought about this. I was not sure if including chrome/browser/history/history_notifications.h here would be fine. I'll redo this patch making FaviconChangedDetails inherit from HistoryDetails again, that will greatly simplify this patch.
	16 FaviconChangedDetails();

	17 ~FaviconChangedDetails();

	18

	19 std::set<GURL> urls;

	20 };

	21

	22 } // namespace chrome

	23

	24 #endif // CHROME_BROWSER_FAVICON_FAVICON_CHANGED_DETAILS_H_

OLD	NEW