Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1527363004: Remove "Adjuststack" instruction opcode. (Closed)

Created:
5 years ago by Karl
Modified:
5 years ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove "Adjuststack" instruction opcode. Both the X86 and ARM header files define "Adjuststack" in the enumeration of target specific opcodes. However, it is not used in either. Removing constant from the enumeration since it is not used. BUG= None R=sehr@chromium.org, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=39f40204b6ef7d880c5dceec69a983a713d8dcf3

Patch Set 1 #

Patch Set 2 : Remove #if 0's. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/IceInstARM32.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/IceInstX86Base.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Karl
5 years ago (2015-12-17 19:12:35 UTC) #3
Jim Stichnoth
lgtm
5 years ago (2015-12-17 19:31:47 UTC) #4
sehr
On 2015/12/17 19:31:47, stichnot wrote: > lgtm LGTM.
5 years ago (2015-12-17 23:06:22 UTC) #5
Karl
5 years ago (2015-12-18 15:45:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
39f40204b6ef7d880c5dceec69a983a713d8dcf3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698