Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1527353003: [Cast, Android, Presentation API] Fix the logic for showing controller vs chooser dialog (Closed)

Created:
5 years ago by whywhat
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

[Cast, Android, Presentation API] Fix the logic for showing controller vs chooser dialog Historically, logic relied on having just one route at all. Now that there might be many routes per connection, if there's a known route with the same source id, we show the chooser dialog, otherwise the picker dialog. BUG=570448 TEST=Manual+e2e tests Review URL: https://codereview.chromium.org/1534553002 Cr-Commit-Position: refs/heads/master@{#365654} (cherry picked from commit 9a35760ec3a0cb170fc4aa00d07d4968da4d1741) Committed: https://chromium.googlesource.com/chromium/src/+/586e9b8b671dafed514aa937df658bd180a1481e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -32 lines) Patch
M chrome/browser/media/android/router/media_router_android.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/media/android/router/media_router_android.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/media/android/router/media_router_dialog_controller_android.h View 3 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/media/android/router/media_router_dialog_controller_android.cc View 3 chunks +7 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
whywhat
5 years ago (2015-12-17 10:13:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
586e9b8b671dafed514aa937df658bd180a1481e.

Powered by Google App Engine
This is Rietveld 408576698