Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 1534553002: [Cast, Android, Presentation API] Fix the logic for showing controller vs chooser dialog (Closed)

Created:
5 years ago by whywhat
Modified:
5 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-join
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast, Android, Presentation API] Fix the logic for showing controller vs chooser dialog Historically, logic relied on having just one route at all. Now that there might be many routes per connection, if there's a known route with the same source id, we show the chooser dialog, otherwise the picker dialog. BUG=570448 TEST=Manual+e2e tests Committed: https://crrev.com/9a35760ec3a0cb170fc4aa00d07d4968da4d1741 Cr-Commit-Position: refs/heads/master@{#365654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -32 lines) Patch
M chrome/browser/media/android/router/media_router_android.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/media/android/router/media_router_android.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/media/android/router/media_router_dialog_controller_android.h View 3 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/media/android/router/media_router_dialog_controller_android.cc View 3 chunks +7 lines, -21 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
whywhat
PTaL
5 years ago (2015-12-16 21:06:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534553002/1
5 years ago (2015-12-16 21:09:54 UTC) #4
imcheng
lgtm
5 years ago (2015-12-16 21:38:05 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-16 22:12:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534553002/1
5 years ago (2015-12-16 22:49:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 22:57:23 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-16 22:59:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a35760ec3a0cb170fc4aa00d07d4968da4d1741
Cr-Commit-Position: refs/heads/master@{#365654}

Powered by Google App Engine
This is Rietveld 408576698