Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: content/browser/background_sync/background_sync_registration.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_sync/background_sync_registration.cc
diff --git a/content/browser/background_sync/background_sync_registration.cc b/content/browser/background_sync/background_sync_registration.cc
index b20e2ef744f7716892692d4d2634d6cd4cfb6085..5625696b10b174127e60c727b2a6eebd6f2e646e 100644
--- a/content/browser/background_sync/background_sync_registration.cc
+++ b/content/browser/background_sync/background_sync_registration.cc
@@ -49,14 +49,14 @@ void BackgroundSyncRegistration::RunFinishedCallbacks() {
bool BackgroundSyncRegistration::HasCompleted() const {
switch (sync_state_) {
- case BACKGROUND_SYNC_STATE_PENDING:
- case BACKGROUND_SYNC_STATE_FIRING:
- case BACKGROUND_SYNC_STATE_REREGISTERED_WHILE_FIRING:
- case BACKGROUND_SYNC_STATE_UNREGISTERED_WHILE_FIRING:
+ case BackgroundSyncState::PENDING:
+ case BackgroundSyncState::FIRING:
+ case BackgroundSyncState::REREGISTERED_WHILE_FIRING:
+ case BackgroundSyncState::UNREGISTERED_WHILE_FIRING:
return false;
- case BACKGROUND_SYNC_STATE_FAILED:
- case BACKGROUND_SYNC_STATE_SUCCESS:
- case BACKGROUND_SYNC_STATE_UNREGISTERED:
+ case BackgroundSyncState::FAILED:
+ case BackgroundSyncState::SUCCESS:
+ case BackgroundSyncState::UNREGISTERED:
return true;
}
NOTREACHED();
@@ -65,14 +65,14 @@ bool BackgroundSyncRegistration::HasCompleted() const {
bool BackgroundSyncRegistration::IsFiring() const {
switch (sync_state_) {
- case BACKGROUND_SYNC_STATE_FIRING:
- case BACKGROUND_SYNC_STATE_REREGISTERED_WHILE_FIRING:
- case BACKGROUND_SYNC_STATE_UNREGISTERED_WHILE_FIRING:
+ case BackgroundSyncState::FIRING:
+ case BackgroundSyncState::REREGISTERED_WHILE_FIRING:
+ case BackgroundSyncState::UNREGISTERED_WHILE_FIRING:
return true;
- case BACKGROUND_SYNC_STATE_PENDING:
- case BACKGROUND_SYNC_STATE_FAILED:
- case BACKGROUND_SYNC_STATE_SUCCESS:
- case BACKGROUND_SYNC_STATE_UNREGISTERED:
+ case BackgroundSyncState::PENDING:
+ case BackgroundSyncState::FAILED:
+ case BackgroundSyncState::SUCCESS:
+ case BackgroundSyncState::UNREGISTERED:
return false;
}
NOTREACHED();
@@ -84,8 +84,8 @@ void BackgroundSyncRegistration::SetUnregisteredState() {
bool is_firing = IsFiring();
- sync_state_ = is_firing ? BACKGROUND_SYNC_STATE_UNREGISTERED_WHILE_FIRING
- : BACKGROUND_SYNC_STATE_UNREGISTERED;
+ sync_state_ = is_firing ? BackgroundSyncState::UNREGISTERED_WHILE_FIRING
+ : BackgroundSyncState::UNREGISTERED;
if (!is_firing) {
// If the registration is currently firing then wait to run

Powered by Google App Engine
This is Rietveld 408576698