chrome/browser/permissions/permission_uma_util.cc - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_manager_unittest.cc ('k') | chrome/browser/push_messaging/push_messaging_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_uma_util.cc

diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc

index 133904dfd76d03b84612d8e4c2eff36d897ab9f5..651ecfec7057b6a79594ffe801354f1bb01dee70 100644

--- a/chrome/browser/permissions/permission_uma_util.cc

+++ b/chrome/browser/permissions/permission_uma_util.cc

@@ -233,9 +233,10 @@ void RecordPermissionRequest(PermissionType permission,

base::HistogramBase* histogram = base::LinearHistogram::FactoryGet(

"Permissions.Requested.CrossOrigin_" +

PermissionUtil::GetPermissionString(permission),

- 1, content::PERMISSION_STATUS_LAST, content::PERMISSION_STATUS_LAST + 1,

+ 1, static_cast<int>(content::PermissionStatus::LAST),

+ static_cast<int>(content::PermissionStatus::LAST) + 1,

base::HistogramBase::kUmaTargetedHistogramFlag);

- histogram->Add(embedding_permission_status);

+ histogram->Add(static_cast<int>(embedding_permission_status));

} else {

UMA_HISTOGRAM_ENUMERATION(

"Permissions.Requested.SameOrigin",