Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_uma_util.h" 5 #include "chrome/browser/permissions/permission_uma_util.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/metrics/histogram_macros.h" 9 #include "base/metrics/histogram_macros.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 content::PermissionManager* manager = profile->GetPermissionManager(); 226 content::PermissionManager* manager = profile->GetPermissionManager();
227 if (!manager) 227 if (!manager)
228 return; 228 return;
229 content::PermissionStatus embedding_permission_status = 229 content::PermissionStatus embedding_permission_status =
230 manager->GetPermissionStatus(permission, embedding_origin, 230 manager->GetPermissionStatus(permission, embedding_origin,
231 embedding_origin); 231 embedding_origin);
232 232
233 base::HistogramBase* histogram = base::LinearHistogram::FactoryGet( 233 base::HistogramBase* histogram = base::LinearHistogram::FactoryGet(
234 "Permissions.Requested.CrossOrigin_" + 234 "Permissions.Requested.CrossOrigin_" +
235 PermissionUtil::GetPermissionString(permission), 235 PermissionUtil::GetPermissionString(permission),
236 1, content::PERMISSION_STATUS_LAST, content::PERMISSION_STATUS_LAST + 1, 236 1, static_cast<int>(content::PermissionStatus::LAST),
237 static_cast<int>(content::PermissionStatus::LAST) + 1,
237 base::HistogramBase::kUmaTargetedHistogramFlag); 238 base::HistogramBase::kUmaTargetedHistogramFlag);
238 histogram->Add(embedding_permission_status); 239 histogram->Add(static_cast<int>(embedding_permission_status));
239 } else { 240 } else {
240 UMA_HISTOGRAM_ENUMERATION( 241 UMA_HISTOGRAM_ENUMERATION(
241 "Permissions.Requested.SameOrigin", 242 "Permissions.Requested.SameOrigin",
242 static_cast<base::HistogramBase::Sample>(permission), 243 static_cast<base::HistogramBase::Sample>(permission),
243 static_cast<base::HistogramBase::Sample>(PermissionType::NUM)); 244 static_cast<base::HistogramBase::Sample>(PermissionType::NUM));
244 } 245 }
245 } 246 }
246 247
247 } // namespace 248 } // namespace
248 249
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 const GURL& revoked_origin) { 281 const GURL& revoked_origin) {
281 // TODO(tsergeant): Expand metrics definitions for revocation to include all 282 // TODO(tsergeant): Expand metrics definitions for revocation to include all
282 // permissions. 283 // permissions.
283 if (permission == PermissionType::NOTIFICATIONS || 284 if (permission == PermissionType::NOTIFICATIONS ||
284 permission == PermissionType::GEOLOCATION || 285 permission == PermissionType::GEOLOCATION ||
285 permission == PermissionType::AUDIO_CAPTURE || 286 permission == PermissionType::AUDIO_CAPTURE ||
286 permission == PermissionType::VIDEO_CAPTURE) { 287 permission == PermissionType::VIDEO_CAPTURE) {
287 RecordPermissionAction(permission, REVOKED, revoked_origin); 288 RecordPermissionAction(permission, REVOKED, revoked_origin);
288 } 289 }
289 } 290 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698