Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1527103005: [d8] Remove "os" object from d8. (Closed)

Created:
5 years ago by Yang
Modified:
4 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8] Remove "os" object from d8. There is no user for it except for one (problematic) test case. It's a nice example and all, but there is no point in having it. R=jkummerow@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1061 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M src/d8.h View 1 chunk +0 lines, -36 lines 0 comments Download
M src/d8.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/d8.gyp View 1 chunk +0 lines, -8 lines 0 comments Download
D src/d8-posix.cc View 1 chunk +0 lines, -791 lines 0 comments Download
D src/d8-windows.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D test/mjsunit/d8-os.js View 1 chunk +0 lines, -188 lines 0 comments Download
M test/mjsunit/mjsunit.status View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years ago (2015-12-16 08:50:46 UTC) #1
Jakob Kummerow
LGTM, but you might want to wait a little longer before landing this to give ...
5 years ago (2015-12-16 09:38:17 UTC) #3
ofrobots
On 2015/12/16 09:38:17, Jakob wrote: > LGTM, but you might want to wait a little ...
5 years ago (2015-12-18 20:18:51 UTC) #4
Igor Sheludko
On 2015/12/18 20:18:51, ofrobots wrote: > On 2015/12/16 09:38:17, Jakob wrote: > > LGTM, but ...
4 years, 11 months ago (2016-01-22 09:10:00 UTC) #5
Yang
4 years, 11 months ago (2016-01-22 09:10:47 UTC) #6
On 2016/01/22 09:10:00, Igor Sheludko wrote:
> On 2015/12/18 20:18:51, ofrobots wrote:
> > On 2015/12/16 09:38:17, Jakob wrote:
> > > LGTM, but you might want to wait a little longer before landing this to
give
> > > people time to raise concerns if they have any.
> > 
> > The tick-processor scripts do use os.system.
> 
> If you ever going to land this, please don't forget to revert this change as
> well: https://codereview.chromium.org/1621523003/

Nope. Closing.

Powered by Google App Engine
This is Rietveld 408576698