Fix a leak in TestingJsonParser.

components/safe_json/testing_json_parser.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/safe_json/testing_json_parser.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/json/json_reader.h"
 #include "base/location.h"
@@ skipping 30 matching lines @@
       error_callback_(error_callback) {}
 
 TestingJsonParser::~TestingJsonParser() {}
 
 void TestingJsonParser::Start() {
   int error_code;
   std::string error;
   scoped_ptr<base::Value> value = base::JSONReader::ReadAndReturnError(
       unsafe_json_, base::JSON_PARSE_RFC, &error_code, &error);
 
-  // Run the callback asynchronously.
+  // Run the callback asynchronously. Post the delete task first, so that the
+  // completion callbacks may quit the run loop without leaking |this|.
+  base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);
   base::MessageLoop::current()->PostTask(
       FROM_HERE, value ? base::Bind(success_callback_, base::Passed(&value))
                        : base::Bind(error_callback_, error));
-  base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);

[Bernhard Bauer, 2015/12/16 08:48:00]

Hm… in principle we could also delete this object directly here, no? No one else
has a pointer to it anyway.

[Robert Sesek, 2015/12/16 15:55:48]

Yeah, that's true, but there's no real difference from this, though.

 }
 
 }  // namespace