apps/app_shim/app_shim_host_manager_mac.h - Issue 15269003: Refactor extension handling code from AppShimHost into ExtensionAppShimHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/app_shim/app_shim_host_manager_mac.h

Issue 15269003: Refactor extension handling code from AppShimHost into ExtensionAppShimHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Change to map of Hosts (no ObserverList). Improve test. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « apps/app_shim/app_shim_host_mac_unittest.cc ('k') | apps/app_shim/app_shim_host_manager_mac.mm » ('j') | apps/app_shim/extension_app_shim_handler_mac.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: apps/app_shim/app_shim_host_manager_mac.h

diff --git a/apps/app_shim/app_shim_host_manager_mac.h b/apps/app_shim/app_shim_host_manager_mac.h

index 13283ee980665f1fe488da4799985829870dfc39..32e7ea6dfa5775304ce36f9d8fef062e0e488e41 100644

--- a/apps/app_shim/app_shim_host_manager_mac.h

+++ b/apps/app_shim/app_shim_host_manager_mac.h

@@ -5,6 +5,7 @@

#ifndef CHROME_BROWSER_WEB_APPLICATIONS_APP_SHIM_HOST_MANAGER_MAC_H_

#define CHROME_BROWSER_WEB_APPLICATIONS_APP_SHIM_HOST_MANAGER_MAC_H_

+#include "apps/app_shim/extension_app_shim_handler_mac.h"

#include "base/mac/scoped_cftyperef.h"

tapted 2013/05/23 07:03:11 while you're here... I think this one and base/thr

jackhou1 2013/05/24 00:12:27 Done.

#include "base/memory/weak_ptr.h"

#include "base/threading/thread.h"

@@ -34,6 +35,8 @@ class AppShimHostManager

scoped_ptr<IPC::ChannelFactory> factory_;

+ apps::ExtensionAppShimHandler extension_app_shim_handler_;

DISALLOW_COPY_AND_ASSIGN(AppShimHostManager);

};