Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: apps/app_shim/app_shim_host_manager_mac.h

Issue 15269003: Refactor extension handling code from AppShimHost into ExtensionAppShimHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change to map of Hosts (no ObserverList). Improve test. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_WEB_APPLICATIONS_APP_SHIM_HOST_MANAGER_MAC_H_ 5 #ifndef CHROME_BROWSER_WEB_APPLICATIONS_APP_SHIM_HOST_MANAGER_MAC_H_
6 #define CHROME_BROWSER_WEB_APPLICATIONS_APP_SHIM_HOST_MANAGER_MAC_H_ 6 #define CHROME_BROWSER_WEB_APPLICATIONS_APP_SHIM_HOST_MANAGER_MAC_H_
7 7
8 #include "apps/app_shim/extension_app_shim_handler_mac.h"
8 #include "base/mac/scoped_cftyperef.h" 9 #include "base/mac/scoped_cftyperef.h"
tapted 2013/05/23 07:03:11 while you're here... I think this one and base/thr
jackhou1 2013/05/24 00:12:27 Done.
9 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
10 #include "base/threading/thread.h" 11 #include "base/threading/thread.h"
11 #include "ipc/ipc_channel_factory.h" 12 #include "ipc/ipc_channel_factory.h"
12 13
13 // The AppShimHostManager receives connections from app shims on a UNIX 14 // The AppShimHostManager receives connections from app shims on a UNIX
14 // socket (|factory_|) and creates a helper object to manage the connection. 15 // socket (|factory_|) and creates a helper object to manage the connection.
15 class AppShimHostManager 16 class AppShimHostManager
16 : public IPC::ChannelFactory::Delegate, 17 : public IPC::ChannelFactory::Delegate,
17 public base::SupportsWeakPtr<AppShimHostManager> { 18 public base::SupportsWeakPtr<AppShimHostManager> {
18 public: 19 public:
19 AppShimHostManager(); 20 AppShimHostManager();
20 virtual ~AppShimHostManager(); 21 virtual ~AppShimHostManager();
21 22
22 private: 23 private:
23 // IPC::ChannelFactory::Delegate implementation. 24 // IPC::ChannelFactory::Delegate implementation.
24 virtual void OnClientConnected(const IPC::ChannelHandle& handle) OVERRIDE; 25 virtual void OnClientConnected(const IPC::ChannelHandle& handle) OVERRIDE;
25 virtual void OnListenError() OVERRIDE; 26 virtual void OnListenError() OVERRIDE;
26 27
27 // The |factory_| must be created on a thread which allows blocking I/O, so 28 // The |factory_| must be created on a thread which allows blocking I/O, so
28 // part of the initialization of this class must be carried out on the file 29 // part of the initialization of this class must be carried out on the file
29 // thread. 30 // thread.
30 void InitOnFileThread(); 31 void InitOnFileThread();
31 32
32 // Called on the IO thread to begin listening for connections from app shims. 33 // Called on the IO thread to begin listening for connections from app shims.
33 void ListenOnIOThread(); 34 void ListenOnIOThread();
34 35
35 scoped_ptr<IPC::ChannelFactory> factory_; 36 scoped_ptr<IPC::ChannelFactory> factory_;
36 37
38 apps::ExtensionAppShimHandler extension_app_shim_handler_;
39
37 DISALLOW_COPY_AND_ASSIGN(AppShimHostManager); 40 DISALLOW_COPY_AND_ASSIGN(AppShimHostManager);
38 }; 41 };
39 42
40 #endif // CHROME_BROWSER_WEB_APPLICATIONS_APP_SHIM_HOST_MANAGER_MAC_H_ 43 #endif // CHROME_BROWSER_WEB_APPLICATIONS_APP_SHIM_HOST_MANAGER_MAC_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698