Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1526883002: Revert of Remove directories in mojo/public/third_party that just mirrored third_party. (Closed)

Created:
5 years ago by hiroshige
Modified:
5 years ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove directories in mojo/public/third_party that just mirrored third_party. (patchset #1 id:1 of https://codereview.chromium.org/1530433002/ ) Reason for revert: Caused compile error: https://build.chromium.org/p/chromium/builders/Linux/builds/69355/ > ImportError: No module named ply Original issue's description: > Remove directories in mojo/public/third_party that just mirrored third_party. > > This isn't needed now that the SDK is in the chrome repo. > > Committed: https://crrev.com/6c123eebf04d2aa9de44e87f4b8e3ee30285113e > Cr-Commit-Position: refs/heads/master@{#365158} TBR=rockot@chromium.org,jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/0899a97fadeb498d71f56b1d7bd1a12f72fa2a69 Cr-Commit-Position: refs/heads/master@{#365169}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16521 lines, -0 lines) Patch
A mojo/public/third_party/README.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/AUTHORS View 1 chunk +33 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/Jinja2-2.7.1.tar.gz.md5 View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/Jinja2-2.7.1.tar.gz.sha512 View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/LICENSE View 1 chunk +31 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/README.chromium View 1 chunk +25 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/__init__.py View 1 chunk +69 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/_compat.py View 1 chunk +150 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/_stringdefs.py View 1 chunk +132 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/bccache.py View 1 chunk +311 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/compiler.py View 1 chunk +1640 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/constants.py View 1 chunk +32 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/debug.py View 1 chunk +337 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/defaults.py View 1 chunk +43 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/environment.py View 1 chunk +1191 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/exceptions.py View 1 chunk +146 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/ext.py View 1 chunk +636 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/filters.py View 1 chunk +987 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/get_jinja2.sh View 1 chunk +123 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/lexer.py View 1 chunk +733 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/loaders.py View 1 chunk +471 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/meta.py View 1 chunk +103 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/nodes.py View 1 chunk +914 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/optimizer.py View 1 chunk +68 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/parser.py View 1 chunk +895 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/runtime.py View 1 chunk +581 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/sandbox.py View 1 chunk +368 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/tests.py View 1 chunk +149 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/utils.py View 1 chunk +520 lines, -0 lines 0 comments Download
A mojo/public/third_party/jinja2/visitor.py View 1 chunk +87 lines, -0 lines 0 comments Download
A mojo/public/third_party/markupsafe/AUTHORS View 1 chunk +13 lines, -0 lines 0 comments Download
A mojo/public/third_party/markupsafe/LICENSE View 1 chunk +33 lines, -0 lines 0 comments Download
A mojo/public/third_party/markupsafe/MarkupSafe-0.18.tar.gz.md5 View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/third_party/markupsafe/MarkupSafe-0.18.tar.gz.sha512 View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/third_party/markupsafe/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A mojo/public/third_party/markupsafe/README.chromium View 1 chunk +24 lines, -0 lines 0 comments Download
A mojo/public/third_party/markupsafe/__init__.py View 1 chunk +234 lines, -0 lines 0 comments Download
A mojo/public/third_party/markupsafe/_compat.py View 1 chunk +24 lines, -0 lines 0 comments Download
A mojo/public/third_party/markupsafe/_constants.py View 1 chunk +267 lines, -0 lines 0 comments Download
A mojo/public/third_party/markupsafe/_native.py View 1 chunk +46 lines, -0 lines 0 comments Download
A mojo/public/third_party/markupsafe/_speedups.c View 1 chunk +239 lines, -0 lines 0 comments Download
A mojo/public/third_party/markupsafe/get_markupsafe.sh View 1 chunk +121 lines, -0 lines 0 comments Download
A mojo/public/third_party/ply/LICENSE View 1 chunk +30 lines, -0 lines 0 comments Download
A mojo/public/third_party/ply/README View 1 chunk +271 lines, -0 lines 0 comments Download
A mojo/public/third_party/ply/README.chromium View 1 chunk +21 lines, -0 lines 0 comments Download
A mojo/public/third_party/ply/__init__.py View 1 chunk +36 lines, -0 lines 0 comments Download
A mojo/public/third_party/ply/lex.py View 1 chunk +1058 lines, -0 lines 0 comments Download
A mojo/public/third_party/ply/license.patch View 1 chunk +41 lines, -0 lines 0 comments Download
A mojo/public/third_party/ply/yacc.py View 1 chunk +3276 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hiroshige
Created Revert of Remove directories in mojo/public/third_party that just mirrored third_party.
5 years ago (2015-12-15 05:51:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526883002/1
5 years ago (2015-12-15 05:52:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 05:55:21 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-15 05:56:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0899a97fadeb498d71f56b1d7bd1a12f72fa2a69
Cr-Commit-Position: refs/heads/master@{#365169}

Powered by Google App Engine
This is Rietveld 408576698