Minor fixes for android test/tools.

Minor fixes for android test/tools.

User lowercase switch for android/common/daemon.cc to
prevent layout tests from hitting DCHECK in
base/command_line.cc.

Stop stripping symbols from android port forwarder.
This allows for symoblizing forwarder crashes.

BUG=555703
Committed: https://crrev.com/0fff8e0c64e4824f3cff5152e1d1be4e40fdbe8b
Cr-Commit-Position: refs/heads/master@{#365304}

[chcunningham, 2015-12-15 00:35:26]

chcunningham@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[Xianzhu, 2015-12-15 01:37:05]

lgtm with one question: are there any other utilities using daemon.cc and other
scripts using '-D'?

[chcunningham, 2015-12-15 02:15:15]

On 2015/12/15 01:37:05, Xianzhu wrote:
> lgtm with one question: are there any other utilities using daemon.cc and
other
> scripts using '-D'?

Thanks!

Its hard to tell with a flag like -D, but I have not managed to find any in my
grepping through code search.
https://code.google.com/p/chromium/codesearch#search/&q=%5B%5C%22'%5Cs%5D-D%5...

I'll kick off try bots now and see if they catch something. 


question: Why have we been stripping symbols off the forwarder? Is it just small
enough that we didn't expect to need to debug it?

[chcunningham, 2015-12-15 02:19:15]

On 2015/12/15 02:15:15, chcunningham wrote:
> On 2015/12/15 01:37:05, Xianzhu wrote:
> > lgtm with one question: are there any other utilities using daemon.cc and
> other
> > scripts using '-D'?
> 
> Thanks!
> 
> Its hard to tell with a flag like -D, but I have not managed to find any in my
> grepping through code search.
> https://code.google.com/p/chromium/codesearch#search/&q=%5B%5C%22
> 
> I'll kick off try bots now and see if they catch something. 
> 
> 
> question: Why have we been stripping symbols off the forwarder? Is it just
small
> enough that we didn't expect to need to debug it?

er, that last link is bad. its not safe to exclude third_party. This one is
better:
https://code.google.com/p/chromium/codesearch#search/&q=%5B%5C%22'%5Cs%5D-D%5...

[Xianzhu, 2015-12-15 02:31:22]

On 2015/12/15 02:15:15, chcunningham wrote:
> On 2015/12/15 01:37:05, Xianzhu wrote:
> > lgtm with one question: are there any other utilities using daemon.cc and
> other
> > scripts using '-D'?
> 
> Thanks!
> 
> Its hard to tell with a flag like -D, but I have not managed to find any in my
> grepping through code search.
> https://code.google.com/p/chromium/codesearch#search/&q=%5B%5C%22

I used
https://code.google.com/p/chromium/codesearch#search/&q=HasNoSpawnDaemonSwitc...
to confirm that forwarder is the only user of the switch.

> 
> I'll kick off try bots now and see if they catch something. 
> 
> 
> question: Why have we been stripping symbols off the forwarder? Is it just
small
> enough that we didn't expect to need to debug it?

Forwarder was written when many phones had very small root partitions. At that
time, we needed Android checkout/build to build Chrome for Android, and we could
put forwarder_symbols under a directory on the host machine where the Android
symbolizer can find.

[chcunningham, 2015-12-15 02:38:12]

Thanks, makes good sense.

[chcunningham, 2015-12-15 02:38:18]

The CQ bit was checked by chcunningham@chromium.org

[commit-bot: I haz the power, 2015-12-15 02:41:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1526833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1526833002/1

[commit-bot: I haz the power, 2015-12-15 04:24:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 04:24:10]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  android_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_android_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[chcunningham, 2015-12-15 08:42:05]

The CQ bit was checked by chcunningham@chromium.org

[commit-bot: I haz the power, 2015-12-15 08:43:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1526833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1526833002/1

[chcunningham, 2015-12-15 08:43:16]

The CQ bit was unchecked by chcunningham@chromium.org

[chcunningham, 2015-12-15 18:46:13]

The CQ bit was checked by chcunningham@chromium.org

[commit-bot: I haz the power, 2015-12-15 18:47:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1526833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1526833002/1

[commit-bot: I haz the power, 2015-12-15 19:07:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-15 19:09:17]

Description was changed from

==========
Minor fixes for android test/tools.

User lowercase switch for android/common/daemon.cc to
prevent layout tests from hitting DCHECK in
base/command_line.cc.

Stop stripping symbols from android port forwarder.
This allows for symoblizing forwarder crashes.

BUG=555703
==========

to

==========
Minor fixes for android test/tools.

User lowercase switch for android/common/daemon.cc to
prevent layout tests from hitting DCHECK in
base/command_line.cc.

Stop stripping symbols from android port forwarder.
This allows for symoblizing forwarder crashes.

BUG=555703

Committed: https://crrev.com/0fff8e0c64e4824f3cff5152e1d1be4e40fdbe8b
Cr-Commit-Position: refs/heads/master@{#365304}
==========

[commit-bot: I haz the power, 2015-12-15 19:09:17]

Patchset 1 (id:??) landed as
https://crrev.com/0fff8e0c64e4824f3cff5152e1d1be4e40fdbe8b
Cr-Commit-Position: refs/heads/master@{#365304}