Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

Issue 1526833002: Minor fixes for android test/tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/android/common/daemon.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2012 Google Inc. All rights reserved. 1 # Copyright (C) 2012 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 1107 matching lines...) Expand 10 before | Expand all | Expand 10 after
1118 self._log_error('Failed to start the content_shell application. Retr ies=%d. Log:%s' % (retries, self._get_logcat())) 1118 self._log_error('Failed to start the content_shell application. Retr ies=%d. Log:%s' % (retries, self._get_logcat()))
1119 self.stop() 1119 self.stop()
1120 time.sleep(2) 1120 time.sleep(2)
1121 self._abort('Failed to start the content_shell application multiple time s. Giving up.') 1121 self._abort('Failed to start the content_shell application multiple time s. Giving up.')
1122 1122
1123 def _start_once(self, pixel_tests, per_test_args): 1123 def _start_once(self, pixel_tests, per_test_args):
1124 super(ChromiumAndroidDriver, self)._start(pixel_tests, per_test_args, wa it_for_ready=False) 1124 super(ChromiumAndroidDriver, self)._start(pixel_tests, per_test_args, wa it_for_ready=False)
1125 1125
1126 self._log_debug('Starting forwarder') 1126 self._log_debug('Starting forwarder')
1127 self._forwarder_process = self._port._server_process_constructor( 1127 self._forwarder_process = self._port._server_process_constructor(
1128 self._port, 'Forwarder', self._android_commands.adb_command() + ['sh ell', '%s -D %s' % (self._driver_details.device_forwarder_path(), FORWARD_PORTS) ]) 1128 self._port, 'Forwarder', self._android_commands.adb_command() + ['sh ell', '%s -no-spawn-daemon %s' % (self._driver_details.device_forwarder_path(), FORWARD_PORTS)])
1129 self._forwarder_process.start() 1129 self._forwarder_process.start()
1130 1130
1131 deadline = time.time() + DRIVER_START_STOP_TIMEOUT_SECS 1131 deadline = time.time() + DRIVER_START_STOP_TIMEOUT_SECS
1132 if not self._wait_for_server_process_output(self._forwarder_process, dea dline, 'Forwarding device port'): 1132 if not self._wait_for_server_process_output(self._forwarder_process, dea dline, 'Forwarding device port'):
1133 return False 1133 return False
1134 1134
1135 self._android_commands.run(['logcat', '-c']) 1135 self._android_commands.run(['logcat', '-c'])
1136 1136
1137 cmd_line_file_path = self._driver_details.command_line_file() 1137 cmd_line_file_path = self._driver_details.command_line_file()
1138 original_cmd_line_file_path = cmd_line_file_path + '.orig' 1138 original_cmd_line_file_path = cmd_line_file_path + '.orig'
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
1286 return command 1286 return command
1287 1287
1288 def _read_prompt(self, deadline): 1288 def _read_prompt(self, deadline):
1289 last_char = '' 1289 last_char = ''
1290 while True: 1290 while True:
1291 current_char = self._server_process.read_stdout(deadline, 1) 1291 current_char = self._server_process.read_stdout(deadline, 1)
1292 if current_char == ' ': 1292 if current_char == ' ':
1293 if last_char in ('#', '$'): 1293 if last_char in ('#', '$'):
1294 return 1294 return
1295 last_char = current_char 1295 last_char = current_char
OLDNEW
« no previous file with comments | « no previous file | tools/android/common/daemon.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698