[telemetry] Catch NoAdbError when killing the adb server.

[telemetry] Catch NoAdbError when killing the adb server.

BUG=567797, 568151
Committed: https://crrev.com/d2faab80fa1d4e178254e4e3e3366423acc6ba15
Cr-Commit-Position: refs/heads/master@{#365102}

[jbudorick, 2015-12-14 18:39:26]

jbudorick@chromium.org changed reviewers:
+ aiolos@chromium.org, nednguyen@google.com

[nednguyen, 2015-12-14 18:43:41]

nednguyen@google.com changed reviewers:
+ achuith@chromium.org

[nednguyen, 2015-12-14 18:45:22]

https://codereview.chromium.org/1526633003/diff/1/tools/telemetry/telemetry/i...
File tools/telemetry/telemetry/internal/platform/android_device.py (right):

https://codereview.chromium.org/1526633003/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/platform/android_device.py:136: """
Can you add logging to figure out why this return True?

[jbudorick, 2015-12-14 18:46:19]

On 2015/12/14 18:45:22, nednguyen wrote:
>
https://codereview.chromium.org/1526633003/diff/1/tools/telemetry/telemetry/i...
> File tools/telemetry/telemetry/internal/platform/android_device.py (right):
> 
>
https://codereview.chromium.org/1526633003/diff/1/tools/telemetry/telemetry/i...
> tools/telemetry/telemetry/internal/platform/android_device.py:136: """
> Can you add logging to figure out why this return True?

sure. 98% sure it's ENOEXEC, though.

[jbudorick, 2015-12-14 19:17:21]

https://codereview.chromium.org/1526633003/diff/1/tools/telemetry/telemetry/i...
File tools/telemetry/telemetry/internal/platform/android_device.py (right):

https://codereview.chromium.org/1526633003/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/platform/android_device.py:136: """
On 2015/12/14 18:45:22, nednguyen wrote:
> Can you add logging to figure out why this return True?

Done.

[nednguyen, 2015-12-14 19:34:28]

lgtm

[jbudorick, 2015-12-14 19:34:38]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2015-12-14 19:36:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1526633003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1526633003/20001

[achuithb, 2015-12-14 20:29:10]

https://codereview.chromium.org/1526633003/diff/20001/tools/telemetry/telemet...
File tools/telemetry/telemetry/internal/platform/android_device.py (right):

https://codereview.chromium.org/1526633003/diff/20001/tools/telemetry/telemet...
tools/telemetry/telemetry/internal/platform/android_device.py:145: if
os.path.isabs(adb_path) and not os.path.exists(adb_path):
Should we add os.access(adb_path, os.X_OK) to this?

[jbudorick, 2015-12-14 20:30:46]

On 2015/12/14 20:29:10, achuithb wrote:
>
https://codereview.chromium.org/1526633003/diff/20001/tools/telemetry/telemet...
> File tools/telemetry/telemetry/internal/platform/android_device.py (right):
> 
>
https://codereview.chromium.org/1526633003/diff/20001/tools/telemetry/telemet...
> tools/telemetry/telemetry/internal/platform/android_device.py:145: if
> os.path.isabs(adb_path) and not os.path.exists(adb_path):
> Should we add os.access(adb_path, os.X_OK) to this?

Yes (in a follow-on CL), but I'm guessing that it's an issue with the wrong
executable format rather than with the executable bit. Could be wrong, though,
and the logging should tell us more.

[achuithb, 2015-12-14 20:34:18]

On 2015/12/14 20:30:46, jbudorick wrote:
> On 2015/12/14 20:29:10, achuithb wrote:
> >
>
https://codereview.chromium.org/1526633003/diff/20001/tools/telemetry/telemet...
> > File tools/telemetry/telemetry/internal/platform/android_device.py (right):
> > 
> >
>
https://codereview.chromium.org/1526633003/diff/20001/tools/telemetry/telemet...
> > tools/telemetry/telemetry/internal/platform/android_device.py:145: if
> > os.path.isabs(adb_path) and not os.path.exists(adb_path):
> > Should we add os.access(adb_path, os.X_OK) to this?
> 
> Yes (in a follow-on CL), but I'm guessing that it's an issue with the wrong
> executable format rather than with the executable bit. Could be wrong, though,
> and the logging should tell us more.

sgtm

[commit-bot: I haz the power, 2015-12-14 21:35:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-14 21:36:45]

Description was changed from

==========
[telemetry] Catch NoAdbError when killing the adb server.

BUG=567797,568151
==========

to

==========
[telemetry] Catch NoAdbError when killing the adb server.

BUG=567797,568151

Committed: https://crrev.com/d2faab80fa1d4e178254e4e3e3366423acc6ba15
Cr-Commit-Position: refs/heads/master@{#365102}
==========

[commit-bot: I haz the power, 2015-12-14 21:36:45]

Patchset 2 (id:??) landed as
https://crrev.com/d2faab80fa1d4e178254e4e3e3366423acc6ba15
Cr-Commit-Position: refs/heads/master@{#365102}