build/android/devil/android/device_errors.py - Issue 1526633003: [telemetry] Catch NoAdbError when killing the adb server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/devil/android/device_errors.py

Issue 1526633003: [telemetry] Catch NoAdbError when killing the adb server. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ned comment Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/devil/android/device_errors.py

diff --git a/build/android/devil/android/device_errors.py b/build/android/devil/android/device_errors.py

index 2fe5a8009434cdc0453071a5e3ceeeffb59ae3fc..ea14bf9ad8b9a7d144ce70fc4cd3559b0541c7b7 100644

--- a/build/android/devil/android/device_errors.py

+++ b/build/android/devil/android/device_errors.py

@@ -112,6 +112,6 @@ class NoDevicesError(base_error.BaseError):

class NoAdbError(base_error.BaseError):

"""Exception for being unable to find ADB."""

- def __init__(self):

+ def __init__(self, msg=None):

super(NoAdbError, self).__init__(

- 'Unable to find adb.', is_infra_error=True)

+ msg or 'Unable to find adb.', is_infra_error=True)

« no previous file with comments | « no previous file | build/android/devil/android/sdk/adb_wrapper.py » ('j') | tools/telemetry/telemetry/internal/platform/android_device.py » ('J')